Message 116284 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	loewis
Recipients	amaury.forgeotdarc, giampaolo.rodola, kristjan.jonsson, loewis, pitrou
Date	2010-09-13.06:47:24
SpamBayes Score	6.5350153e-10
Marked as misclassified	No
Message-id	<1284360449.24.0.597303908848.issue9786@psf.upfronthosting.co.za>
In-reply-to

Content
It seems we need to clarify the return value of PyThread_create_key. The patch returns 0 in case of failure, which is clearly wrong as 0 is also a valid key. I think it's safe to return -1: TlsAlloc returns TLS_OUT_OF_INDEXES, which is 0xFFFFFFFF, i.e. -1 on a 32-bit system.

It seems we need to clarify the return value of PyThread_create_key. The patch returns 0 in case of failure, which is clearly wrong as 0 is also a valid key.

I think it's safe to return -1: TlsAlloc returns TLS_OUT_OF_INDEXES, which is 0xFFFFFFFF, i.e. -1 on a 32-bit system.

History
Date	User	Action	Args
2010-09-13 06:47:29	loewis	set	recipients: + loewis, amaury.forgeotdarc, pitrou, kristjan.jonsson, giampaolo.rodola
2010-09-13 06:47:29	loewis	set	messageid: <1284360449.24.0.597303908848.issue9786@psf.upfronthosting.co.za>
2010-09-13 06:47:24	loewis	link	issue9786 messages
2010-09-13 06:47:24	loewis	create