Message 122707 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	rhettinger
Recipients	catlee, eric.araujo, jhylton, orsenthil, rcoyner, rhettinger, xuanji
Date	2010-11-28.19:10:13
SpamBayes Score	0.0006871264
Marked as misclassified	No
Message-id	<1290971414.92.0.0620817460889.issue3243@psf.upfronthosting.co.za>
In-reply-to

Content
Instead of hasattr(str,'next') consider using isinstance(str, collections.Iterable) Also consider changing the variable name from the now overly type specific, "str" to something like "source" to indicate the significance of the data, not its type.

Instead of 
    hasattr(str,'next')

consider using
    isinstance(str, collections.Iterable)

Also consider changing the variable name from the now overly type specific, "str" to something like "source" to indicate the significance of the data, not its type.

History
Date	User	Action	Args
2010-11-28 19:10:14	rhettinger	set	recipients: + rhettinger, jhylton, orsenthil, catlee, eric.araujo, rcoyner, xuanji
2010-11-28 19:10:14	rhettinger	set	messageid: <1290971414.92.0.0620817460889.issue3243@psf.upfronthosting.co.za>
2010-11-28 19:10:13	rhettinger	link	issue3243 messages
2010-11-28 19:10:13	rhettinger	create