Message 130588 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	pitrou
Recipients	eltoder, mark.dickinson, pitrou, rhettinger
Date	2011-03-11.16:52:58
SpamBayes Score	4.8304244e-08
Marked as misclassified	No
Message-id	<1299862375.3732.4.camel@localhost.localdomain>
In-reply-to	<1299862291.59.0.935746271232.issue11462@psf.upfronthosting.co.za>

Content
> > - why the "#ifndef NDEBUG" path? > These entries in the table should not be used, but if something slips > through and uses one of them, it's much easier to tell if we remap to > invalid value. As this is an internal check, I didn't want it in > release mode. If this is deemed unnecessary or confusing I can remove > it. I think it is confusing indeed. If you want to do a check in debug mode only, just use assert() (and perhaps add a comment if the check doesn't look obvious).

> > - why the "#ifndef NDEBUG" path?
> These entries in the table should not be used, but if something slips
> through and uses one of them, it's much easier to tell if we remap to
> invalid value. As this is an internal check, I didn't want it in
> release mode. If this is deemed unnecessary or confusing I can remove
> it.

I think it is confusing indeed. If you want to do a check in debug mode
only, just use assert() (and perhaps add a comment if the check doesn't
look obvious).

History
Date	User	Action	Args
2011-03-11 16:52:59	pitrou	set	recipients: + pitrou, rhettinger, mark.dickinson, eltoder
2011-03-11 16:52:58	pitrou	link	issue11462 messages
2011-03-11 16:52:58	pitrou	create