Message 130659 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	eltoder
Recipients	belopolsky, eltoder, mark.dickinson, pitrou, rhettinger, twouters
Date	2011-03-12.03:49:12
SpamBayes Score	4.759878e-05
Marked as misclassified	No
Message-id	<1299901753.47.0.193976118792.issue11462@psf.upfronthosting.co.za>
In-reply-to

Content
Alexander, my patch does 2 optimizations: doesn't insert a new constant if one already exist and removes unused constants after peephole is done. You patch seems to do only the latter. It's very similar, from a quick look at your patch: - My patch doesn't introduce any additional passes over the code (you added 2 passes). - It preserves doc string. - It's less code, because I reuse more of existing code. Feel free to look at the patch and tell me if you don't agree.

Alexander, my patch does 2 optimizations: doesn't insert a new constant if one already exist and removes unused constants after peephole is done. You patch seems to do only the latter. It's very similar, from a quick look at your patch:
- My patch doesn't introduce any additional passes over the code (you added 2 passes).
- It preserves doc string.
- It's less code, because I reuse more of existing code.

Feel free to look at the patch and tell me if you don't agree.

History
Date	User	Action	Args
2011-03-12 03:49:13	eltoder	set	recipients: + eltoder, twouters, rhettinger, mark.dickinson, belopolsky, pitrou
2011-03-12 03:49:13	eltoder	set	messageid: <1299901753.47.0.193976118792.issue11462@psf.upfronthosting.co.za>
2011-03-12 03:49:12	eltoder	link	issue11462 messages
2011-03-12 03:49:12	eltoder	create