Message 145133 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	rosslagerwall
Recipients	eric.araujo, hynek, mrts, petri.lehtinen, pitrou, rosslagerwall, schmir, tarek, teamnoir
Date	2011-10-07.19:34:36
SpamBayes Score	0.008214554
Marked as misclassified	No
Message-id	<1318016077.51.0.919401901316.issue4489@psf.upfronthosting.co.za>
In-reply-to

Content
http://bugs.python.org/review/4489/diff/3383/10563#newcode319 Lib/test/test_shutil.py:319: @unittest.skipIf(threading == None, 'requires threading') On 2011/10/07 19:29:47, eric.araujo wrote: > You can just say skipUnless(threading, 'msg') Right. http://bugs.python.org/review/4489/diff/3383/10563#newcode344 Lib/test/test_shutil.py:344: raise On 2011/10/07 19:29:47, eric.araujo wrote: > Shouldn’t this use self.fail? I would have thought it's better if the original exception is passed through and displayed rather than some sort of failure message that just says "OSError occurred".

http://bugs.python.org/review/4489/diff/3383/10563#newcode319
Lib/test/test_shutil.py:319: @unittest.skipIf(threading == None, 'requires
threading')
On 2011/10/07 19:29:47, eric.araujo wrote:
> You can just say skipUnless(threading, 'msg')

Right.

http://bugs.python.org/review/4489/diff/3383/10563#newcode344
Lib/test/test_shutil.py:344: raise
On 2011/10/07 19:29:47, eric.araujo wrote:
> Shouldn’t this use self.fail?

I would have thought it's better if the original exception is passed through and
displayed rather than some sort of failure message that just says "OSError
occurred".

History
Date	User	Action	Args
2011-10-07 19:34:37	rosslagerwall	set	recipients: + rosslagerwall, pitrou, schmir, tarek, eric.araujo, mrts, teamnoir, petri.lehtinen, hynek
2011-10-07 19:34:37	rosslagerwall	set	messageid: <1318016077.51.0.919401901316.issue4489@psf.upfronthosting.co.za>
2011-10-07 19:34:36	rosslagerwall	link	issue4489 messages
2011-10-07 19:34:36	rosslagerwall	create