Message 158474 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	brett.cannon
Recipients	Arfrever, berker.peksag, brett.cannon, eric.araujo, eric.snow, meador.inge, pitrou, python-dev
Date	2012-04-16.15:48:30
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1334591311.23.0.134163970162.issue13959@psf.upfronthosting.co.za>
In-reply-to

Content
From Eric Smith on python-dev: > + suffix, mode, type_ = details > + if mode and (not mode.startswith(('r', 'U'))) or '+' in mode: > + raise ValueError('invalid file open mode {!r}'.format(mode)) Should this be: if mode and (not mode.startswith(('r', 'U')) or '+' in mode): to match: > - if (mode) { ... > - if (!(mode == 'r' \|\| *mode == 'U') \|\| strchr(mode, '+')) { > - PyErr_Format(PyExc_ValueError, > - "invalid file open mode %.200s", mode);

From Eric Smith on python-dev:

> +    suffix, mode, type_ = details
> +    if mode and (not mode.startswith(('r', 'U'))) or '+' in mode:
> +        raise ValueError('invalid file open mode {!r}'.format(mode))

Should this be:
if mode and (not mode.startswith(('r', 'U')) or '+' in mode):

to match:

> -    if (*mode) {
...
> -        if (!(*mode == 'r' || *mode == 'U') || strchr(mode, '+')) {
> -            PyErr_Format(PyExc_ValueError,
> -                         "invalid file open mode %.200s", mode);

History
Date	User	Action	Args
2012-04-16 15:48:31	brett.cannon	set	recipients: + brett.cannon, pitrou, eric.araujo, Arfrever, meador.inge, python-dev, eric.snow, berker.peksag
2012-04-16 15:48:31	brett.cannon	set	messageid: <1334591311.23.0.134163970162.issue13959@psf.upfronthosting.co.za>
2012-04-16 15:48:30	brett.cannon	link	issue13959 messages
2012-04-16 15:48:30	brett.cannon	create