Message 163366 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	loewis
Recipients	Jon.Oberheide, alex, christian.heimes, fijall, georg.brandl, hynek, loewis, ncoghlan, petri.lehtinen, pitrou, python-dev, serhiy.storchaka
Date	2012-06-21.21:00:41
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<4FE38B78.3080403@v.loewis.de>
In-reply-to	<1340312157.2703.17.camel@raxxla>

Content
> The user can just do timingsafe_eq(a.decode('ascii'), > b.decode('ascii')). You mean .encode()? > I do not see a necessity in support of unicode > strings. Support ASCII strings will create the false impression that all > strings are supported. I agree. > About code. Instead (PyBytes_CheckExact(a) && PyBytes_CheckExact(b)) you > should use ((PyBytes_CheckExact(a) != 0) & (PyBytes_CheckExact(b) != > 0)). What's the difference? They are the same.

> The user can just do timingsafe_eq(a.decode('ascii'),
> b.decode('ascii')). 

You mean .encode()?

> I do not see a necessity in support of unicode
> strings. Support ASCII strings will create the false impression that all
> strings are supported.

I agree.

> About code. Instead (PyBytes_CheckExact(a) && PyBytes_CheckExact(b)) you
> should use ((PyBytes_CheckExact(a) != 0) & (PyBytes_CheckExact(b) !=
> 0)).

What's the difference? They are the same.

History
Date	User	Action	Args
2012-06-21 21:00:43	loewis	set	recipients: + loewis, georg.brandl, ncoghlan, pitrou, christian.heimes, alex, fijall, python-dev, petri.lehtinen, hynek, serhiy.storchaka, Jon.Oberheide
2012-06-21 21:00:42	loewis	link	issue15061 messages
2012-06-21 21:00:41	loewis	create