Message 184835 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	rhettinger
Recipients	alex, asvetlov, benjamin.peterson, eric.araujo, eric.snow, ezio.melotti, flox, rhettinger, serhiy.storchaka
Date	2013-03-21.03:04:44
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1363835085.16.0.781427790952.issue16991@psf.upfronthosting.co.za>
In-reply-to

Content
I just looked at the test-collections patch and don't want it committed. It is full of trivial edits that make it hard to review and doesn't make the test suite better. It is okay to add some new tests, but I don't want to rearrange the existing code with minor edits. That will just make it more difficult to maintain the code across versions (it is no fun to backport a fix and then have unnecessary merge conflicts).

I just looked at the test-collections patch and don't want it committed.  It is full of trivial edits that make it hard to review and doesn't make the test suite better.

It is okay to add some new tests, but I don't want to rearrange the existing code with minor edits.  That will just make it more difficult to maintain the code across versions (it is no fun to backport a fix and then have unnecessary merge conflicts).

History
Date	User	Action	Args
2013-03-21 03:04:45	rhettinger	set	recipients: + rhettinger, benjamin.peterson, ezio.melotti, eric.araujo, alex, asvetlov, flox, eric.snow, serhiy.storchaka
2013-03-21 03:04:45	rhettinger	set	messageid: <1363835085.16.0.781427790952.issue16991@psf.upfronthosting.co.za>
2013-03-21 03:04:45	rhettinger	link	issue16991 messages
2013-03-21 03:04:44	rhettinger	create