Message 205985 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	vstinner
Recipients	Arfrever, grahamd, kristjan.jonsson, neologix, pitrou, tim.peters, vstinner
Date	2013-12-12.21:59:23
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1386885563.72.0.372138036129.issue19787@psf.upfronthosting.co.za>
In-reply-to

Content
If I understand correctly, there is probably only one application (mod_python) which might be broken by fix_set_key_value.patch. If an application is broken by fix_set_key_value.patch, it can get the old behaviour using: int PyThread_set_key_value33(int key, void value) { #if PY_VERSION_HEX >= 0x03040000 void oldValue = PyThread_get_key_value(key); if (oldValue != NULL) return 0; #endif return PyThread_set_key_value(key, value); } So are you ok to apply the bugfix in Python 3.4?

If I understand correctly, there is probably only one application (mod_python) which might be broken by fix_set_key_value.patch.

If an application is broken by fix_set_key_value.patch, it can get the old behaviour using:

int
PyThread_set_key_value33(int key, void *value)
{
#if PY_VERSION_HEX >= 0x03040000
    void *oldValue = PyThread_get_key_value(key);
    if (oldValue != NULL)
        return 0;
#endif
    return PyThread_set_key_value(key, value);
}

So are you ok to apply the bugfix in Python 3.4?

History
Date	User	Action	Args
2013-12-12 21:59:23	vstinner	set	recipients: + vstinner, tim.peters, pitrou, kristjan.jonsson, grahamd, Arfrever, neologix
2013-12-12 21:59:23	vstinner	set	messageid: <1386885563.72.0.372138036129.issue19787@psf.upfronthosting.co.za>
2013-12-12 21:59:23	vstinner	link	issue19787 messages
2013-12-12 21:59:23	vstinner	create