Message 219480 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	sstewartgallus
Recipients	akira, gregory.p.smith, larry, sstewartgallus
Date	2014-06-01.02:29:04
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1401589745.51.0.260315171311.issue21618@psf.upfronthosting.co.za>
In-reply-to

Content
I found another problem with _close_open_fd_range_safe. POSIX leaves the state of a file descriptor given to close undefined if the close fails with EINTR. I believe but haven't double checked that close should not be retried on EINTR on all of our supported platforms. If you must have absolute portability, block all signals so that close can't fail with EINTR and then unblock them after close. This isn't an actual problem because the code will just close an extra time but it's still bothersome.

I found another problem with _close_open_fd_range_safe. POSIX leaves
the state of a file descriptor given to close undefined if the close
fails with EINTR. I believe but haven't double checked that close
should not be retried on EINTR on all of our supported platforms. If
you must have absolute portability, block all signals so that close
can't fail with EINTR and then unblock them after close. This isn't an
actual problem because the code will just close an extra time but it's
still bothersome.

History
Date	User	Action	Args
2014-06-01 02:29:05	sstewartgallus	set	recipients: + sstewartgallus, gregory.p.smith, larry, akira
2014-06-01 02:29:05	sstewartgallus	set	messageid: <1401589745.51.0.260315171311.issue21618@psf.upfronthosting.co.za>
2014-06-01 02:29:05	sstewartgallus	link	issue21618 messages
2014-06-01 02:29:04	sstewartgallus	create