Message 230277 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	r.david.murray
Recipients	Joshua.Chin, ethan.furman, r.david.murray, rhettinger
Date	2014-10-30.17:50:23
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1414691423.06.0.116795201411.issue22766@psf.upfronthosting.co.za>
In-reply-to

Content
'counter' in the docstrings is in lower case, so that says nothing dispositive. However, __add__ does an ininstance check, so it is hard to see why __iadd__ does not. Personally I'd drop the isinstance checks and let the errors bubble up as they may. Why should subtract explicitly support other data types, but not __sub__/__isub__? But Raymond's opinion should hold the most weight here.

'counter' in the docstrings is in lower case, so that says nothing dispositive.  However, __add__ does an ininstance check, so it is hard to see why __iadd__ does not.

Personally I'd drop the isinstance checks and let the errors bubble up as they may.  Why should subtract explicitly support other data types, but not __sub__/__isub__?  But Raymond's opinion should hold the most weight here.

History
Date	User	Action	Args
2014-10-30 17:50:23	r.david.murray	set	recipients: + r.david.murray, rhettinger, ethan.furman, Joshua.Chin
2014-10-30 17:50:23	r.david.murray	set	messageid: <1414691423.06.0.116795201411.issue22766@psf.upfronthosting.co.za>
2014-10-30 17:50:23	r.david.murray	link	issue22766 messages
2014-10-30 17:50:23	r.david.murray	create