Message 237399 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	demian.brecht
Recipients	berker.peksag, chad.birch, cvrebert, demian.brecht, martin.panter, orsenthil, serhiy.storchaka
Date	2015-03-06.23:35:27
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1425684928.02.0.213426487052.issue20059@psf.upfronthosting.co.za>
In-reply-to

Content
> It is surprising that urlsplit() does not raise any exception I have a bit of a TL;DR in #20271, trying to capture what the responsibilities of split and parse methods in urllib are and what they should be if consistency is something that we're after. Around the patch though: It seems quite odd to me to be raising exceptions on accessors rather than on instantiation or when the parsing occurs (in the body of urlparse). Wouldn't it better to raise the exception there?

> It is surprising that urlsplit() does not raise any exception

I have a bit of a TL;DR in #20271, trying to capture what the responsibilities of split and parse methods in urllib are and what they should be if consistency is something that we're after.


Around the patch though:

It seems quite odd to me to be raising exceptions on accessors rather than on instantiation or when the parsing occurs (in the body of urlparse). Wouldn't it better to raise the exception there?

History
Date	User	Action	Args
2015-03-06 23:35:28	demian.brecht	set	recipients: + demian.brecht, orsenthil, cvrebert, berker.peksag, martin.panter, serhiy.storchaka, chad.birch
2015-03-06 23:35:28	demian.brecht	set	messageid: <1425684928.02.0.213426487052.issue20059@psf.upfronthosting.co.za>
2015-03-06 23:35:28	demian.brecht	link	issue20059 messages
2015-03-06 23:35:27	demian.brecht	create