Message 239277 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	josiahcarlson
Recipients	Andrew.Boettcher, ajaksu2, akira, astrand, cvrebert, ericpruitt, eryksun, giampaolo.rodola, gvanrossum, janzert, josiahcarlson, martin.panter, ooooooooo, parameter, r.david.murray, rosslagerwall, sbt, techtonik, v+python, vstinner, yselivanov
Date	2015-03-25.18:32:16
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1427308339.85.0.885121028309.issue1191964@psf.upfronthosting.co.za>
In-reply-to

Content
I'm going to be honest; seeing None being returned from a pipe read feels really broken to me. When I get None returned from an IO read operation, my first instinct is "there can't be anything else coming, why else would it return None?" After changing writing to raise BrokenPipeError on a closed pipe, I've also changed reading to do the same and added a test to verify the behavior.

I'm going to be honest; seeing None being returned from a pipe read feels *really* broken to me. When I get None returned from an IO read operation, my first instinct is "there can't be anything else coming, why else would it return None?"

After changing writing to raise BrokenPipeError on a closed pipe, I've also changed reading to do the same and added a test to verify the behavior.

History
Date	User	Action	Args
2015-03-25 18:32:21	josiahcarlson	set	recipients: + josiahcarlson, gvanrossum, astrand, parameter, vstinner, techtonik, giampaolo.rodola, ajaksu2, ooooooooo, v+python, r.david.murray, cvrebert, ericpruitt, akira, Andrew.Boettcher, rosslagerwall, sbt, martin.panter, janzert, yselivanov, eryksun
2015-03-25 18:32:19	josiahcarlson	set	messageid: <1427308339.85.0.885121028309.issue1191964@psf.upfronthosting.co.za>
2015-03-25 18:32:19	josiahcarlson	link	issue1191964 messages
2015-03-25 18:32:19	josiahcarlson	create