Message 263187 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	xiang.zhang
Recipients	ncoghlan, xiang.zhang, yselivanov
Date	2016-04-11.15:29:39
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1460388579.51.0.228134373774.issue26733@psf.upfronthosting.co.za>
In-reply-to

Content
After researching the code, I think changing ' %-4d' to '%3d' in dis_bug708901 is right. Since I added some some lines and the lineno of test_bug708901 has arrived at 100+ and the leading space should not be there. According to the code of dis.dis, the right format string should be '%3d'. Not only test_bug708901, all the other ' %-4d' should be changed to '%3d'. If we add 1000+ lines at the head of the file, then all the ' %-4d' format string will lead to test failures. I update my patch.

After researching the code, I think changing ' %-4d' to '%3d' in dis_bug708901 is right. Since I added some some lines and the lineno of test_bug708901 has arrived at 100+ and the leading space should not be there. According to the code of dis.dis, the right format string should be '%3d'. Not only test_bug708901, all the other ' %-4d' should be changed to '%3d'. If we add 1000+ lines at the head of the file, then all the ' %-4d' format string will lead to test failures.

I update my patch.

History
Date	User	Action	Args
2016-04-11 15:29:39	xiang.zhang	set	recipients: + xiang.zhang, ncoghlan, yselivanov
2016-04-11 15:29:39	xiang.zhang	set	messageid: <1460388579.51.0.228134373774.issue26733@psf.upfronthosting.co.za>
2016-04-11 15:29:39	xiang.zhang	link	issue26733 messages
2016-04-11 15:29:39	xiang.zhang	create