Message 280772 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	mdk
Recipients	elliot.gorokhovsky, mdk, tim.peters
Date	2016-11-14.13:09:50
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1479128990.79.0.773886734459.issue28685@psf.upfronthosting.co.za>
In-reply-to

Content
Hi Elliot, nice spot! Why are you redefining Py_ABS, which looks already defined in `pymacro.h` included itself by `Python.h`? I'm not fan of undefining it later, it may surprise someone later expecting it to be there. I tried to compile without your definition of Py_ABS, just in case I missed something in the includes, and it works.

Hi Elliot, nice spot!

Why are you redefining Py_ABS, which looks already defined in `pymacro.h` included itself by `Python.h`? I'm not fan of undefining it later, it may surprise someone later expecting it to be there.

I tried to compile without your definition of Py_ABS, just in case I missed something in the includes, and it works.

History
Date	User	Action	Args
2016-11-14 13:09:51	mdk	set	recipients: + mdk, tim.peters, elliot.gorokhovsky
2016-11-14 13:09:50	mdk	set	messageid: <1479128990.79.0.773886734459.issue28685@psf.upfronthosting.co.za>
2016-11-14 13:09:50	mdk	link	issue28685 messages
2016-11-14 13:09:50	mdk	create