Message 291508 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	pitrou
Recipients	Lukasa, christian.heimes, pitrou, thehesiod
Date	2017-04-11.17:57:35
SpamBayes Score	-1.0
Marked as misclassified	Yes
Message-id	<1491933455.52.0.248902185909.issue29870@psf.upfronthosting.co.za>
In-reply-to

Content
The following addition fixes the leak: diff --git a/Modules/_ssl.c b/Modules/_ssl.c index bb40051..8f5facd 100644 --- a/Modules/_ssl.c +++ b/Modules/_ssl.c @@ -1203,6 +1203,8 @@ _get_crl_dp(X509 *certificate) { Py_XDECREF(lst); #if OPENSSL_VERSION_NUMBER < 0x10001000L sk_DIST_POINT_free(dps); +#else + CRL_DIST_POINTS_free(dps); #endif return res; } Christian, what do you think?

The following addition fixes the leak:

diff --git a/Modules/_ssl.c b/Modules/_ssl.c
index bb40051..8f5facd 100644
--- a/Modules/_ssl.c
+++ b/Modules/_ssl.c
@@ -1203,6 +1203,8 @@ _get_crl_dp(X509 *certificate) {
     Py_XDECREF(lst);
 #if OPENSSL_VERSION_NUMBER < 0x10001000L
     sk_DIST_POINT_free(dps);
+#else
+    CRL_DIST_POINTS_free(dps);
 #endif
     return res;
 }


Christian, what do you think?

History
Date	User	Action	Args
2017-04-11 17:57:35	pitrou	set	recipients: + pitrou, christian.heimes, Lukasa, thehesiod
2017-04-11 17:57:35	pitrou	set	messageid: <1491933455.52.0.248902185909.issue29870@psf.upfronthosting.co.za>
2017-04-11 17:57:35	pitrou	link	issue29870 messages
2017-04-11 17:57:35	pitrou	create