Message 72070 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	amaury.forgeotdarc
Recipients	amaury.forgeotdarc, henry.precheur, pitrou
Date	2008-08-28.08:02:22
SpamBayes Score	2.3707722e-07
Marked as misclassified	No
Message-id	<1219910544.2.0.744985895096.issue3696@psf.upfronthosting.co.za>
In-reply-to

Content
> Another small remark; #ifdef is better then #ifndef > Simply because it easier to get "Be positive" than "Don't be negative". Yes; but here, the symbol (HAVE_BROKEN_MBSTOWC) has a negative meaning. I tried to put the optimistic (=not broken) case first. However, if this makes the code more difficult to read, I'll change it.

> Another small remark; #ifdef is better then #ifndef 
> Simply because it easier to get "Be positive" than "Don't be negative".

Yes; but here, the symbol (HAVE_BROKEN_MBSTOWC) has a negative meaning.
I tried to put the optimistic (=not broken) case first.
However, if this makes the code more difficult to read, I'll change it.

History
Date	User	Action	Args
2008-08-28 08:02:24	amaury.forgeotdarc	set	recipients: + amaury.forgeotdarc, pitrou, henry.precheur
2008-08-28 08:02:24	amaury.forgeotdarc	set	messageid: <1219910544.2.0.744985895096.issue3696@psf.upfronthosting.co.za>
2008-08-28 08:02:23	amaury.forgeotdarc	link	issue3696 messages
2008-08-28 08:02:22	amaury.forgeotdarc	create