Message 73126 - Python tracker

➜

This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Author	tim.peters
Recipients	amaury.forgeotdarc, barry, benjamin.peterson, nnorwitz, tim.peters
Date	2008-09-12.19:28:54
SpamBayes Score	6.056084e-05
Marked as misclassified	No
Message-id	<1221247735.11.0.280771762014.issue3657@psf.upfronthosting.co.za>
In-reply-to

Content
No thought went into picking random.random in the test -- it was just a random ;-) choice. Amaury's analysis of the source of non-determinism is on target, and the easiest fix is to pick a coded-in-Python function to pickle instead. I suggest, e.g., changing the sporadically failing doctest to: >>> import pickletools >>> dis(pickle.dumps(pickletools.dis, 0)) 0: c GLOBAL 'pickletools dis' 17: p PUT 0 20: . STOP highest protocol among opcodes = 0

No thought went into picking random.random in the test -- it was just a
random ;-) choice.  Amaury's analysis of the source of non-determinism
is on target, and the easiest fix is to pick a coded-in-Python function
to pickle instead.  I suggest, e.g., changing the sporadically failing
doctest to:

>>> import pickletools
>>> dis(pickle.dumps(pickletools.dis, 0))
    0: c    GLOBAL     'pickletools dis'
   17: p    PUT        0
   20: .    STOP
highest protocol among opcodes = 0

History
Date	User	Action	Args
2008-09-12 19:28:55	tim.peters	set	recipients: + tim.peters, barry, nnorwitz, amaury.forgeotdarc, benjamin.peterson
2008-09-12 19:28:55	tim.peters	set	messageid: <1221247735.11.0.280771762014.issue3657@psf.upfronthosting.co.za>
2008-09-12 19:28:54	tim.peters	link	issue3657 messages
2008-09-12 19:28:54	tim.peters	create