◐ Shell
reader mode source ↗
Skip to content

X509#7

Open
jdahmubed wants to merge 5 commits into
masterfrom
x509
Open

X509#7
jdahmubed wants to merge 5 commits into
masterfrom
x509

Conversation

@jdahmubed

Copy link
Copy Markdown
Contributor

No description provided.

@jdahmubed jdahmubed requested a review from TMSCH December 20, 2017 22:49
@lccodes lccodes requested a review from lbalmaceda January 10, 2018 17:25
63 hidden conversations Load more…

@lbalmaceda lbalmaceda left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

General things:

  • Keep the PR short. This is already long and needs to be shrinked.
  • Avoid pressing the hotkey to reorder imports as they generate excessive and unnecessary diff. Rollback those changes if possible.
  • Don't change the logic of the existing tests. They are there for a reason.
  • Either use the constants on the tests or on the exported classes, not in both.
  • Don't export files you don't want people to have
  • Don't add methods that throw an exception because "they shouldn't be called".

Important one: Any public API changes are to be discussed with the team. Pause the coding and create a doc to discuss this.

9 hidden conversations Load more…
@TMSCH TMSCH removed their request for review May 23, 2018 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants