{{ message }}
Conversation
lccodes
reviewed
Dec 21, 2017
lccodes
reviewed
Dec 21, 2017
lyzhang27
reviewed
Dec 21, 2017
lyzhang27
reviewed
Dec 21, 2017
lyzhang27
reviewed
Dec 21, 2017
lyzhang27
reviewed
Dec 21, 2017
lbalmaceda
requested changes
Jan 15, 2018
63 hidden conversations
Load more…
lbalmaceda
requested changes
Mar 8, 2018
lbalmaceda
left a comment
Collaborator
There was a problem hiding this comment.
General things:
- Keep the PR short. This is already long and needs to be shrinked.
- Avoid pressing the hotkey to reorder imports as they generate excessive and unnecessary diff. Rollback those changes if possible.
- Don't change the logic of the existing tests. They are there for a reason.
- Either use the constants on the tests or on the exported classes, not in both.
- Don't export files you don't want people to have
- Don't add methods that throw an exception because "they shouldn't be called".
Important one: Any public API changes are to be discussed with the team. Pause the coding and create a doc to discuss this.
Sorry, something went wrong.
9 hidden conversations
Load more…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
No description provided.