{{ message }}
scss -> styled component 변환, footer 컴포넌트화, 버그수정 2개#24
Merged
yongchanson merged 8 commits intoJun 14, 2022
Merged
Conversation
codeisneverodd
left a comment
Member
There was a problem hiding this comment.
고생 많으셨습니다!!
1번은 아래에 footer.js 에 답변 남겼고 나머지에 대해 리뷰 남길게요!
2. 동적으로 생성되는 div 에 styled-componets를 적용하지 못했다는 말을 이해하지 못했어요! 동적으로 생성된다는 것이 어떠한 data를 기반으로 그 데이터를 기반으로 DOM 객체를 새롭게 생성한다는 말일텐데, 생성하는 로직에 styled-component 를 쓰면 된다고 생각해요! 이 부분은 다시 전달 부탁드릴게요
3, 4은 인지 했습니다! 좋은 것 같아요!
Sorry, something went wrong.
4 hidden conversations
Load more…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
변경사항
<ThemeProvider>를 추가하여 전역으로 theme를 사용할 수 있도록 함궁금한점
<ThemeProvider>의{theme}처럼 사용하고 싶습니다.min-width: 2500px; width: 100%;