{{ message }}
Fix tbb-compat linking after rename#236
Merged
kevinushey merged 1 commit intoJun 11, 2025
Merged
Conversation
Contributor
Sorry, something went wrong.
Contributor
Author
|
It doesn't happen with the GCC-based x86_64 toolchain, but it does with the LLVM-based aarch64 toolchain - odd! |
Sorry, something went wrong.
Hide details
View details
kevinushey
merged commit
kevinushey
merged commit aa28b17
into
RcppCore:master
Jun 11, 2025
3 checks passed
Contributor
|
Thanks! |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Unsure if it's because of clang or windows arm64, but
rstanmodels compiled against the current githubRcppParallelfail at runtime with an error thattbb-compat.dllis not found - even though the DLL has been renamed totbb.dllbefore being linked.I believe this is because
R CMD SHLIBgenerates a.deffile when linking with the name of the DLL. Explicitly setting the output name totbb.dllwhen callingR CMD SHLIBresolves the later runtime errors for me