◐ Shell
reader mode source ↗
Skip to content

Fix f-string format spec#3532

Merged
youknowone merged 4 commits into
RustPython:mainfrom
fanninpm:fix-fstring-format-spec
Feb 10, 2022
Merged

Fix f-string format spec#3532
youknowone merged 4 commits into
RustPython:mainfrom
fanninpm:fix-fstring-format-spec

Conversation

@fanninpm

@fanninpm fanninpm commented Feb 2, 2022

Copy link
Copy Markdown
Contributor

I was using CPython 3.9's Lib/test/test_fstring.py as an implementation guide to track my progress, but there's still a long way to go, particularly w/r/t escape sequences.

Should fix #3531.

@fanninpm

fanninpm commented Feb 2, 2022

Copy link
Copy Markdown
Contributor Author

Now, CI is blocked by mmap not being present (c.f. #2059)

@youknowone

youknowone commented Feb 3, 2022

Copy link
Copy Markdown
Member

is this happened because get-pip.py is changed?

@fanninpm

fanninpm commented Feb 3, 2022

Copy link
Copy Markdown
Contributor Author

I think that it's because pip itself is vendoring dependencies that we currently don't support.

@fanninpm fanninpm force-pushed the fix-fstring-format-spec branch from b51ae20 to ef64b21 Compare February 3, 2022 21:20
@fanninpm fanninpm force-pushed the fix-fstring-format-spec branch from ef64b21 to a936c36 Compare February 4, 2022 19:59
@youknowone

youknowone commented Feb 6, 2022

Copy link
Copy Markdown
Member

great, thank you!

youknowone
youknowone approved these changes Feb 6, 2022
View reviewed changes

@youknowone youknowone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

looks good to me, but I am not very familiar with this part. so I want to let a few days for @coolreader18's review.

@fanninpm fanninpm mentioned this pull request Feb 8, 2022
Closed
@youknowone youknowone merged commit 37e8842 into RustPython:main Feb 10, 2022
@fanninpm fanninpm deleted the fix-fstring-format-spec branch February 11, 2022 02:35
@fanninpm fanninpm mentioned this pull request Jun 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

@coolreader18 coolreader18 Awaiting requested review from coolreader18

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bad f-string, causing CI issues

2 participants

@fanninpm @youknowone