◐ Shell
reader mode source ↗
Skip to content

Fix decorators#3783

Merged
youknowone merged 13 commits into
RustPython:mainfrom
ChJR:feature/fix_decorators
Jul 16, 2022
Merged

Fix decorators#3783
youknowone merged 13 commits into
RustPython:mainfrom
ChJR:feature/fix_decorators

Conversation

@ChJR

@ChJR ChJR commented Jun 12, 2022

Copy link
Copy Markdown
Contributor

Except test_expressions in test_decorators.py file.

Now it is working with full test_decorators.py test file.

@fanninpm

Copy link
Copy Markdown
Contributor

test_socket.py needs an update; I can tackle that later.

@youknowone

Copy link
Copy Markdown
Member

related to #3742

@ChJR ChJR force-pushed the feature/fix_decorators branch from a77ae32 to f2e62cf Compare June 21, 2022 14:37
@ChJR

ChJR commented Jul 10, 2022

Copy link
Copy Markdown
Contributor Author

Good points. I will change the codes.

@youknowone

Copy link
Copy Markdown
Member

dependency of #3862

ChJR added 2 commits July 16, 2022 21:16
Check 'Named Expressions Need Not Be Parenthesized' Section

@youknowone youknowone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

looks good, thank you for contributing!

@youknowone

youknowone commented Jul 16, 2022

Copy link
Copy Markdown
Member

oh, this is unexpected errors ok, that's solved by retry

@youknowone youknowone merged commit d9d4538 into RustPython:main Jul 16, 2022
@ChJR ChJR deleted the feature/fix_decorators branch July 17, 2022 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants