◐ Shell
reader mode source ↗
Skip to content

Update traceback#3855

Merged
youknowone merged 3 commits into
RustPython:mainfrom
youknowone:update-traceback
Jul 15, 2022
Merged

Update traceback#3855
youknowone merged 3 commits into
RustPython:mainfrom
youknowone:update-traceback

Conversation

@youknowone

@youknowone youknowone commented Jul 10, 2022 •
edited
Loading

Copy link
Copy Markdown
Member

No description provided.

@youknowone youknowone mentioned this pull request Jul 10, 2022
Closed
@youknowone

youknowone commented Jul 10, 2022

Copy link
Copy Markdown
Member Author

dependency of #3862

@youknowone youknowone marked this pull request as ready for review July 15, 2022 17:29
@youknowone youknowone requested a review from fanninpm July 15, 2022 17:29
@fanninpm

fanninpm commented Jul 15, 2022

Copy link
Copy Markdown
Contributor

I think we should wait for CI to finish before merging.

On a tangential note, do you want to add Bors to this repository?

@youknowone

youknowone commented Jul 15, 2022

Copy link
Copy Markdown
Member Author

Bors is great. I want to have one, if I don't need to manage it myself.

@youknowone

youknowone commented Jul 15, 2022

Copy link
Copy Markdown
Member Author

huh... the result of running cargo run Lib/test/test_traceback.py and cargo run -- -m test test_traceback are different.

@fanninpm

fanninpm commented Jul 15, 2022

Copy link
Copy Markdown
Contributor

huh... the result of running cargo run Lib/test/test_traceback.py and cargo run -- -m test test_traceback are different.

Hence why I made #3807.

@youknowone

youknowone commented Jul 15, 2022

Copy link
Copy Markdown
Member Author

I though both of running should pass. Does former one also fail in CPython?

@youknowone youknowone merged commit e5e98b7 into RustPython:main Jul 15, 2022
@youknowone youknowone deleted the update-traceback branch July 15, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fanninpm fanninpm fanninpm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@youknowone @fanninpm