{{ message }}
Optimize bytes-like (l|r)strip#4500
Merged
youknowone merged 4 commits intoFeb 17, 2023
Merged
Conversation
Contributor
Sorry, something went wrong.
youknowone
reviewed
Feb 15, 2023
fanninpm
reviewed
Feb 15, 2023
fanninpm
left a comment
fanninpm
left a comment
Contributor
There was a problem hiding this comment.
Does this work? I don't think we need the explicit conversion in these two places, as PartialEq<&[U]> is implemented for Vec<T, A>.
Sorry, something went wrong.
dannasman
requested review from
fanninpm and
youknowone
and removed request for
fanninpm and
youknowone
February 17, 2023 08:22
youknowone
approved these changes
Feb 17, 2023
youknowone
left a comment
youknowone
left a comment
Member
There was a problem hiding this comment.
Great, Thank you!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Hi!
Here is a solution proposal to #4497. I was not quite sure what the optimization part of #4496 was (I assumed it was the if-else part).