Pathconf names#4508
Conversation
|
After CI completes, feel free to do a |
Sorry, something went wrong.
f1e488a to
21072f9
Compare
February 17, 2023 12:32
|
I rebased it. |
Sorry, something went wrong.
Thanks -- I was looking at trying to do that but it didn't seem to look right as I still ended up with 2 additional changes -- I was thinking my baseline wasn't quite right or I did something incorrectly. |
Sorry, something went wrong.
|
I'm looking at the error -- I found an online free online macos simlulator and was able to get the error 22 manually trying the command os.pathconf('/',21) but that isn't conclusive. (pathconf worked for indexes 0-20). It looks like there are some platforms which may have pathconf indexes that are greater then 20 (e.g. in libc I suppose this is more a of libc specfic question does anyone know how can I tell which of the libc flavor will be used on macos/darwin? (and therefore which pathconf indexes value will show up in PathconfVar) Clarifying - As a result I suspect there may be a value in PathconVar which isn't valid for pathconf on that platform.... (and causing the error) The test could be simplified to only check a few manually selected values rather , but if this is actually I think it would be better to fix PathconfVar to have the correct values for the platform. |
Sorry, something went wrong.
ba0da32 to
8b09202
Compare
February 21, 2023 10:26
There was a problem hiding this comment.
You don't need to fix every macOS issue if if you don't have macOS machine. Please fill free to ask help if you have hard trouble to fix.
I think adding it only for linux is a working option now. I made a change about it. We can fix macOS issue later.
Thank you for contributing!
Sorry, something went wrong.
8b09202 to
955347e
Compare
February 21, 2023 10:45
|
Thank you for contributing! |
Sorry, something went wrong.
|
Thanks! |
Sorry, something went wrong.
Implementation for os.pathconf_names resolves #4494