{{ message }}
Update _compression, gzip, and test_gzip for CPython v3.11.2#4688
Merged
youknowone merged 2 commits intoMar 15, 2023
Merged
Conversation
Contributor
Sorry, something went wrong.
youknowone
reviewed
Mar 13, 2023
youknowone
left a comment
youknowone
left a comment
Member
There was a problem hiding this comment.
That's really good decision 😄
thank you!
Sorry, something went wrong.
youknowone
approved these changes
Mar 15, 2023
youknowone
left a comment
youknowone
left a comment
Member
There was a problem hiding this comment.
looks good, thank you!
Sorry, something went wrong.
youknowone
force-pushed
the
compression
branch
3 times, most recently
from
13687c3 to
407f3f5
Compare
March 15, 2023 14:15
fanninpm
reviewed
Mar 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
Updated
_compression.pyto match CPython v3.11.2. I didn't see any immediate unit test for this, so it seemed fit to test using a library that relies on_compression.py. I updatedgzip.py/test_gzip.pyand accounted for the unexpected failures ontest_gzip.py.The failures were primarily wbit errors tracing to
stdlib/src/zlib.rs, but I am not familiar enough with this module in rust to correct the issues.