◐ Shell
reader mode source ↗
Skip to content

update test_builtin.py from cpython v3.11.2#4765

Merged
DimitrisJim merged 4 commits into
RustPython:mainfrom
JaeyoungAhn:built_in
Mar 25, 2023
Merged

update test_builtin.py from cpython v3.11.2#4765
DimitrisJim merged 4 commits into
RustPython:mainfrom
JaeyoungAhn:built_in

Conversation

@JaeyoungAhn

@JaeyoungAhn JaeyoungAhn commented Mar 25, 2023

Copy link
Copy Markdown
Contributor

#4564 update test_builtin.py from cpython v3.11.2

@DimitrisJim

DimitrisJim commented Mar 25, 2023

Copy link
Copy Markdown
Member

thanks! There's some additional regressions here which should be noted: test_delattr, test_getattr, test_hasattr and test_setattr should probably all be related. test_type_name is also failing now.

@DimitrisJim DimitrisJim mentioned this pull request Mar 25, 2023
Closed
DimitrisJim
DimitrisJim approved these changes Mar 25, 2023
View reviewed changes

@DimitrisJim DimitrisJim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

hopefully should be good to go now.

@DimitrisJim DimitrisJim merged commit cfed9f3 into RustPython:main Mar 25, 2023
@youknowone youknowone added A-design About RustPython's own implementation z-ca-2023 Tag to track contrubution-academy 2023 labels Mar 25, 2023
@youknowone youknowone added A-stdlib and removed A-design About RustPython's own implementation labels Mar 25, 2023
@DimitrisJim DimitrisJim mentioned this pull request Mar 27, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone left review comments

@fanninpm fanninpm fanninpm left review comments

@DimitrisJim DimitrisJim DimitrisJim approved these changes

Assignees

No one assigned

Labels

A-stdlib z-ca-2023 Tag to track contrubution-academy 2023

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JaeyoungAhn @DimitrisJim @youknowone @fanninpm