◐ Shell
reader mode source ↗
Skip to content

update test_ordered_dict.py from cpython 3.11.2#4775

Closed
sapsalian wants to merge 1 commit into
RustPython:mainfrom
sapsalian:updateorderddicttest
Closed

update test_ordered_dict.py from cpython 3.11.2#4775
sapsalian wants to merge 1 commit into
RustPython:mainfrom
sapsalian:updateorderddicttest

Conversation

@sapsalian

@sapsalian sapsalian commented Mar 26, 2023

Copy link
Copy Markdown
Contributor

update test_ordered_dict.py from cpython 3.11.2

@youknowone youknowone added A-stdlib z-ca-2023 Tag to track contrubution-academy 2023 labels Mar 26, 2023
@DimitrisJim

DimitrisJim commented Mar 27, 2023

Copy link
Copy Markdown
Member

Thanks! The results have some failures and some successes. Failures:

test.test_ordered_dict.CSimpleLRUCacheTests.test_pop
test.test_ordered_dict.PySimpleLRUCacheTests.test_pop

and the unexpected successes:

test.test_ordered_dict.CPythonOrderedDictSubclassTests.test_copying
test.test_ordered_dict.CPythonOrderedDictSubclassTests.test_pop
test.test_ordered_dict.CPythonOrderedDictTests.test_copying
test.test_ordered_dict.CPythonOrderedDictTests.test_pop
test.test_ordered_dict.PurePythonOrderedDictSubclassTests.test_copying
test.test_ordered_dict.PurePythonOrderedDictSubclassTests.test_pop
test.test_ordered_dict.PurePythonOrderedDictTests.test_copying
test.test_ordered_dict.PurePythonOrderedDictTests.test_pop

@DimitrisJim

DimitrisJim commented Apr 12, 2023

Copy link
Copy Markdown
Member

Superseded by #4846, thanks for opening the PR though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fanninpm fanninpm fanninpm requested changes

Assignees

No one assigned

Labels

A-stdlib z-ca-2023 Tag to track contrubution-academy 2023

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sapsalian @DimitrisJim @fanninpm @youknowone