◐ Shell
reader mode source ↗
Skip to content

Update enum to CPython 3.11.5#5074

Merged
youknowone merged 3 commits into
RustPython:mainfrom
dvermd:enum_311
Oct 3, 2023
Merged

Update enum to CPython 3.11.5#5074
youknowone merged 3 commits into
RustPython:mainfrom
dvermd:enum_311

Conversation

@dvermd

@dvermd dvermd commented Oct 1, 2023

Copy link
Copy Markdown
Contributor

No description provided.

@fanninpm fanninpm mentioned this pull request Oct 2, 2023
Closed
@dvermd dvermd force-pushed the enum_311 branch 2 times, most recently from a41534e to d03904c Compare October 2, 2023 19:39
@dvermd

dvermd commented Oct 2, 2023

Copy link
Copy Markdown
Contributor Author

ruff has been updated from 0.0.291 to 0.0.292 today which seem to cause this parsing error.
Do you know where extra_tests/snippets/syntax_fstring.py comes from ? Can this line be deleted ?

@fanninpm

fanninpm commented Oct 2, 2023

Copy link
Copy Markdown
Contributor

ruff has been updated from 0.0.291 to 0.0.292 today which seem to cause this parsing error. Do you know where extra_tests/snippets/syntax_fstring.py comes from ? Can this line be deleted ?

This might be in conjunction with CPython 3.12.0 also being released today.

@youknowone

youknowone commented Oct 3, 2023

Copy link
Copy Markdown
Member

I don't believe the result of ruff run is related to CPython version. It must have been triggered by ruff update

@youknowone

youknowone commented Oct 3, 2023

Copy link
Copy Markdown
Member

I reported this to Ruff project astral-sh/ruff#7778
I will also pin ruff version to 0.0.291 for a while to avoid this error

@youknowone @fanninpm
Comment related ruff issue …
41098c9 
Co-authored-by: fanninpm <fanninpm@miamioh.edu>
youknowone
youknowone approved these changes Oct 3, 2023
View reviewed changes

@youknowone youknowone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

👍

@youknowone youknowone merged commit 0d0139b into RustPython:main Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fanninpm fanninpm

@youknowone youknowone

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dvermd @fanninpm @youknowone