{{ message }}
Fix best_base to select proper base class#5324
Merged
youknowone merged 7 commits intoMay 19, 2024
Merged
Conversation
Contributor
Sorry, something went wrong.
youknowone
reviewed
May 16, 2024
Snowapril
force-pushed
the
best_base
branch
2 times, most recently
from
0964777 to
d3e7b31
Compare
May 18, 2024 08:44
Contributor
Author
|
I can't reproduce |
Sorry, something went wrong.
youknowone
reviewed
May 19, 2024
Signed-off-by: snowapril <sinjihng@gmail.com>
youknowone
approved these changes
May 19, 2024
youknowone
left a comment
youknowone
left a comment
Member
There was a problem hiding this comment.
Thank you!
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
This revision implements
itemsizeslots and fixbest_baseimplementation to select proper base class when generating class.