Switch to libz-rs-sys for zlib implementation#5562
Conversation
Sorry, something went wrong.
|
if it is a pure rust implementation, do we still need a |
Sorry, something went wrong.
|
It's a reasonably heavy dependency (~500KB), so I figured it might be nice to still have the option to turn it off. |
Sorry, something went wrong.
coolreader18
force-pushed
the
zlib-rs
branch
from
f69087f to
62bf9ae
Compare
February 26, 2025 02:45
|
We don't suggest feature for every library which can be a redundant dependencies. If the binary size matters, turning off the entire stdlib feature and consist their own well-selected (or we can suggest a few pre-selected) set of libraries will make more sense. |
Sorry, something went wrong.
|
Fair enough. |
Sorry, something went wrong.
coolreader18
force-pushed
the
zlib-rs
branch
2 times, most recently
from
6e740d9 to
3887f7c
Compare
February 26, 2025 02:55
coolreader18
force-pushed
the
zlib-rs
branch
from
3887f7c to
00b8559
Compare
February 26, 2025 02:57
|
Probably we can remove zlib feature from |
Sorry, something went wrong.
This is a rust-only reimplementation of the
libz-sysapi, which I discovered from this blog post. It can build without any C toolchain, which makes it a good pick for us when we're targeting windows and wasm, and the performance isn't anything to scoff at (see blog post). Also, thezlibfeature now enables the entirezlibmodule, which I feel like just makes more sense.