{{ message }}
Cleanup match statement codegen#5700
Merged
coolreader18 merged 10 commits intoApr 18, 2025
Merged
Conversation
Contributor
Sorry, something went wrong.
Contributor
Author
|
Matching classes causes a stack underflow, no clue why. That's for a different pr though. |
Sorry, something went wrong.
coolreader18
approved these changes
Apr 16, 2025
coolreader18
left a comment
coolreader18
left a comment
Member
There was a problem hiding this comment.
lgtm! lmk when you feel it's ready to be merged.
Sorry, something went wrong.
youknowone
approved these changes
Apr 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
3 participants
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
#5628 was a little chaotic.
Instruction::IsOperationtodo!)extra_testsand the test only checks for compile.