{{ message }}
Switch to libbz2-rs-sys and finish bz2 impl#5709
Merged
coolreader18 merged 3 commits intoApr 20, 2025
Merged
Conversation
Contributor
|
This one is better than mine ... |
Sorry, something went wrong.
Member
|
please check #5605 and rebase on it or pick some idea if possible |
Sorry, something went wrong.
Member
Author
|
Oh, shoot, sorry - I didn't see that that PR was open. |
Sorry, something went wrong.
arihant2math
requested changes
Apr 18, 2025
arihant2math
approved these changes
Apr 19, 2025
youknowone
reviewed
Apr 19, 2025
Merged
Contributor
|
I checkout out of this pr for #5717 so try not to change the trait too much 😄 . |
Sorry, something went wrong.
Co-authored-by: Ashwin Naren <arihant2math@gmail.com>
youknowone
approved these changes
Apr 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
I realized that
libbz2-rs-sysexists, by the same folks who makelibz-rs-sys- it's a Rust reimplementation oflibbz2. This means we can do that same thing as in #5562, and avoid having to cross-compile C. I then realized after I removed the feature flag that we weren't actually running bz2 regrtests in CI, because we weren't passing it as a feature to cargo build, and so something like half of the tests intest_bz2.pywere failing. So, I more or less finished up the impl, by making some code inzlib.rsgeneric over the specificDecompressstruct.