◐ Shell
reader mode source ↗
Skip to content

Switch to libbz2-rs-sys and finish bz2 impl#5709

Merged
coolreader18 merged 3 commits into
RustPython:mainfrom
coolreader18:bz2
Apr 20, 2025
Merged

Switch to libbz2-rs-sys and finish bz2 impl#5709
coolreader18 merged 3 commits into
RustPython:mainfrom
coolreader18:bz2

Conversation

@coolreader18

@coolreader18 coolreader18 commented Apr 17, 2025

Copy link
Copy Markdown
Member

I realized that libbz2-rs-sys exists, by the same folks who make libz-rs-sys - it's a Rust reimplementation of libbz2. This means we can do that same thing as in #5562, and avoid having to cross-compile C. I then realized after I removed the feature flag that we weren't actually running bz2 regrtests in CI, because we weren't passing it as a feature to cargo build, and so something like half of the tests in test_bz2.py were failing. So, I more or less finished up the impl, by making some code in zlib.rs generic over the specific Decompress struct.

@fanninpm

Copy link
Copy Markdown
Contributor

See also #5605

@arihant2math

Copy link
Copy Markdown
Contributor

This one is better than mine ... test_shutil is the only fail (due to 1 new exposed test) and there aren't too many expected failures comparatively. I'll close mine after this is merged.

@youknowone

Copy link
Copy Markdown
Member

please check #5605 and rebase on it or pick some idea if possible

@coolreader18

Copy link
Copy Markdown
Member Author

Oh, shoot, sorry - I didn't see that that PR was open.

@arihant2math

Copy link
Copy Markdown
Contributor

I checkout out of this pr for #5717 so try not to change the trait too much 😄 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants