◐ Shell
reader mode source ↗
Skip to content

Configure dependabot to ignore ruff updates#6185

Merged
youknowone merged 4 commits into
RustPython:mainfrom
ShaharNaveh:depebdabot-ignore-ruff
Oct 12, 2025
Merged

Configure dependabot to ignore ruff updates#6185
youknowone merged 4 commits into
RustPython:mainfrom
ShaharNaveh:depebdabot-ignore-ruff

Conversation

@ShaharNaveh

@ShaharNaveh ShaharNaveh commented Oct 7, 2025

Copy link
Copy Markdown
Contributor

Explained in .github/dependabot.yml the motivation for this.

Closes #6183
Closes #6184

Summary by CodeRabbit

  • Chores
    • Updated dependency management configuration to ignore updates for specific Rust-related dependencies matching “ruff_*”.
    • Reduces unnecessary update notifications and keeps dependency update noise low without impacting app functionality.

@coderabbitai

coderabbitai Bot commented Oct 7, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

Added a Dependabot ignore rule for Cargo deps matching ruff_*; bumped lexical-parse-float from 1.0.4 to 1.0.6 in compiler/literal/Cargo.toml; replaced a guarded build() call with build_unchecked() when constructing the lexical number format in compiler/literal/src/float.rs.

Changes

Cohort / File(s) Summary
Dependabot configuration
.github/dependabot.yml
Added an ignore rule for Cargo dependencies matching ruff_* with explanatory comments; no other schedule or ecosystem changes.
Compiler crate manifest
compiler/literal/Cargo.toml
Bumped dependency lexical-parse-float from 1.0.4 to 1.0.6 (features: format) — no API or feature changes declared.
Float parsing logic
compiler/literal/src/float.rs
Switched from a guarded NumberFormatBuilder::build() to build_unchecked() for the PYTHON_STRING format when calling parse_inner, removing runtime validation during format construction.

Sequence Diagram(s)

sequenceDiagram
    autonumber
    participant Caller as parse_inner caller
    participant Builder as NumberFormatBuilder
    participant Parser as lexical parse routine

    Note over Caller,Builder: Before
    Caller->>Builder: build() (validates)
    Builder-->>Caller: Result<Format, Error> (may Err)
    alt valid
        Caller->>Parser: parse_with_format(format)
        Parser-->>Caller: Result<f64, ParseError>
    else invalid
        Builder-->>Caller: Error
    end

    Note over Caller,Builder: After (changed)
    Caller->>Builder: build_unchecked() (no validation)
    Builder-->>Caller: Format (assumed valid)
    Caller->>Parser: parse_with_format(format)
    Parser-->>Caller: Result<f64, ParseError or UB-like behavior if format invalid)
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

I nibble code with careful paws,
A tiny hop to guard the cause.
Skip the ruff, bump a float’s thread,
Build unchecked — I twitch my head.
Carrot cheers for tidy laws. 🥕

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title clearly identifies the addition of a dependabot ignore rule for ruff updates, which is a key part of the changeset and is neither misleading nor generic. It directly reflects a real aspect of the PR, meeting the criteria for a concise and focused title.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ShaharNaveh ShaharNaveh changed the title Depebdabot ignore ruff Oct 7, 2025

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Actionable comments posted: 0

🧹 Nitpick comments (1)
.github/dependabot.yml (1)

9-10: Fix typo in comment.

Please correct “dealling” → “dealing” to keep the comment polished.

📜 Review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3a6fda4 and e26f313.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • .github/dependabot.yml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
  • GitHub Check: Run snippets and cpython tests on wasm-wasi
  • GitHub Check: Run rust tests (windows-2025)
  • GitHub Check: Run snippets and cpython tests (ubuntu-latest)
  • GitHub Check: Check the WASM package and demo
  • GitHub Check: Run snippets and cpython tests (macos-latest)
  • GitHub Check: Ensure compilation on various targets
  • GitHub Check: Run tests under miri
  • GitHub Check: Run snippets and cpython tests (windows-2025)

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Actionable comments posted: 2

📜 Review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e26f313 and a8c36ad.

📒 Files selected for processing (3)
  • .github/dependabot.yml (1 hunks)
  • compiler/literal/Cargo.toml (1 hunks)
  • compiler/literal/src/float.rs (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/dependabot.yml
🧰 Additional context used
📓 Path-based instructions (1)
**/*.rs

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

**/*.rs: Format Rust code with the default rustfmt style (run cargo fmt)
Run clippy and fix any warnings or lints introduced by your changes
Follow Rust best practices for error handling and memory management

Files:

  • compiler/literal/src/float.rs
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
  • GitHub Check: Run snippets and cpython tests on wasm-wasi
  • GitHub Check: Check the WASM package and demo
  • GitHub Check: Run snippets and cpython tests (ubuntu-latest)
  • GitHub Check: Run snippets and cpython tests (macos-latest)
  • GitHub Check: Run snippets and cpython tests (windows-2025)
  • GitHub Check: Run rust tests (ubuntu-latest)
  • GitHub Check: Run rust tests (windows-2025)
  • GitHub Check: Run rust tests (macos-latest)
  • GitHub Check: Check Rust code with rustfmt and clippy
  • GitHub Check: Ensure compilation on various targets

@ShaharNaveh ShaharNaveh changed the title Configure depebdabot to ignore ruff updates Oct 7, 2025
Hide details View details @youknowone youknowone merged commit c979059 into RustPython:main Oct 12, 2025
12 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Dec 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants