◐ Shell
reader mode source ↗
Skip to content

Move compiler/codegen -> crates/codegen#6260

Merged
youknowone merged 3 commits into
RustPython:mainfrom
ShaharNaveh:move-compiler-codegen
Nov 15, 2025
Merged

Move compiler/codegen -> crates/codegen#6260
youknowone merged 3 commits into
RustPython:mainfrom
ShaharNaveh:move-compiler-codegen

Conversation

@ShaharNaveh

@ShaharNaveh ShaharNaveh commented Nov 14, 2025

Copy link
Copy Markdown
Contributor

ref: #6214

Summary by CodeRabbit

  • Chores
    • Reorganized project configuration and internal dependencies.
    • Updated the internal codegen package location within the workspace to reflect repository structure changes.

@coderabbitai

coderabbitai Bot commented Nov 14, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

The workspace manifest (Cargo.toml) was updated: the codegen workspace member was moved from compiler/codegen to crates/codegen, and the rustpython-codegen workspace dependency path was adjusted; the package version remains 0.4.0.

Changes

Cohort / File(s) Change Summary
Workspace manifest
Cargo.toml
Removed compiler/codegen from [workspace] members and changed rustpython-codegen workspace dependency path from compiler/codegencrates/codegen (version unchanged: 0.4.0).

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Single manifest edit; low logic complexity but affects workspace layout.
  • Review attention:
    • Ensure no other workspace members or CI/scripting reference compiler/codegen.
    • Confirm crates/codegen/Cargo.toml exists and has correct package metadata.

Possibly related PRs

Poem

🐰 A hop from compiler to crates I go,

Tiny paws patter, tidy rows in tow.
Codegen shifted, paths made right,
I nibble carrots, then rest tonight. 🥕✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly and specifically describes the main change: moving the compiler/codegen directory from compiler/ to crates/ location, which matches the actual modifications in Cargo.toml.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@fanninpm

Copy link
Copy Markdown
Contributor

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Nov 14, 2025

Copy link
Copy Markdown
Contributor
✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 609d99f and b63b29c.

⛔ Files ignored due to path filters (8)
  • crates/codegen/src/snapshots/rustpython_codegen__compile__tests__if_ands.snap is excluded by !**/*.snap
  • crates/codegen/src/snapshots/rustpython_codegen__compile__tests__if_mixed.snap is excluded by !**/*.snap
  • crates/codegen/src/snapshots/rustpython_codegen__compile__tests__if_ors.snap is excluded by !**/*.snap
  • crates/codegen/src/snapshots/rustpython_codegen__compile__tests__nested_double_async_with.snap is excluded by !**/*.snap
  • crates/codegen/src/snapshots/rustpython_compiler_core__compile__tests__if_ands.snap is excluded by !**/*.snap
  • crates/codegen/src/snapshots/rustpython_compiler_core__compile__tests__if_mixed.snap is excluded by !**/*.snap
  • crates/codegen/src/snapshots/rustpython_compiler_core__compile__tests__if_ors.snap is excluded by !**/*.snap
  • crates/codegen/src/snapshots/rustpython_compiler_core__compile__tests__nested_double_async_with.snap is excluded by !**/*.snap
📒 Files selected for processing (1)
  • Cargo.toml (1 hunks)

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b63b29c and 07a93c7.

📒 Files selected for processing (1)
  • Cargo.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
  • GitHub Check: Run snippets and cpython tests (macos-latest)
  • GitHub Check: Run snippets and cpython tests (windows-latest)
  • GitHub Check: Run snippets and cpython tests (ubuntu-latest)
  • GitHub Check: Check Rust code with clippy
  • GitHub Check: Run rust tests (windows-latest)
  • GitHub Check: Run rust tests (macos-latest)
  • GitHub Check: Run rust tests (ubuntu-latest)
  • GitHub Check: Ensure compilation on various targets
  • GitHub Check: Run snippets and cpython tests on wasm-wasi
  • GitHub Check: Check the WASM package and demo
  • GitHub Check: auto_format

Hide details View details @youknowone youknowone merged commit 7f45ba4 into RustPython:main Nov 15, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants