◐ Shell
reader mode source ↗
Skip to content

Update test_smtpnet.py from 3.13.11#6435

Merged
youknowone merged 9 commits into
RustPython:mainfrom
ShaharNaveh:update-test-smtpnet
Dec 19, 2025
Merged

Update test_smtpnet.py from 3.13.11#6435
youknowone merged 9 commits into
RustPython:mainfrom
ShaharNaveh:update-test-smtpnet

Conversation

@ShaharNaveh

@ShaharNaveh ShaharNaveh commented Dec 13, 2025

Copy link
Copy Markdown
Contributor

Related to: #6410

@coderabbitai

coderabbitai Bot commented Dec 13, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (3)
  • Lib/smtplib.py is excluded by !Lib/**
  • Lib/test/test_smtplib.py is excluded by !Lib/**
  • Lib/test/test_smtpnet.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@fanninpm

fanninpm commented Dec 15, 2025

Copy link
Copy Markdown
Contributor

It seems like Lib/smtplib.py also needs to be updated.

youknowone
youknowone approved these changes Dec 19, 2025
View reviewed changes

@youknowone youknowone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

👍

Hide details View details @youknowone youknowone merged commit 6c186e3 into RustPython:main Dec 19, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ShaharNaveh @fanninpm @youknowone