Bump libsqlite3-sys from 0.28 to 0.36#6472

ever0de

Update libsqlite3-sys to version 0.36 and adapt to API changes by
replacing sqlite3_close_v2 with sqlite3_close. The v2 variant is no
longer directly exported in the newer version.

ref

Summary by CodeRabbit

Chores
- Updated SQLite library dependency to version 0.36.
- Adjusted internal SQLite API calls for improved compatibility with the latest library version.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Update libsqlite3-sys to version 0.36 and adapt to API changes by replacing sqlite3_close_v2 with sqlite3_close. The v2 variant is no longer directly exported in the newer version. Fixes RustPython#6471

coderabbitai

📝 Walkthrough

Walkthrough

Updated libsqlite3-sys dependency from 0.28 to 0.36 and adjusted SQLite API usage to maintain compatibility: replaced sqlite3_close_v2 with sqlite3_close and removed explicit type casts from SQLITE_TRACE_STMT usage to align with the new library version's exported symbols.

Changes

Cohort / File(s)	Summary
Dependency Update `crates/stdlib/Cargo.toml`	Upgraded libsqlite3-sys from `0.28` to `0.36` in conditional target dependencies for non-Android and non-WASM builds
SQLite API Compatibility `crates/stdlib/src/sqlite.rs`	Replaced `sqlite3_close_v2` with `sqlite3_close` in extern imports and Drop implementation; removed explicit `as u32` casts from `SQLITE_TRACE_STMT` constant usage in callback registration

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

youknowone

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%.	You can run `@coderabbitai generate docstrings` to improve docstring coverage.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Bump libsqlite3-sys from 0.28 to 0.36' directly and accurately summarizes the main change in the PR, which is updating the dependency version.
Linked Issues check	✅ Passed	The PR successfully addresses issue #6471 by replacing sqlite3_close_v2 with sqlite3_close in crates/stdlib/src/sqlite.rs to resolve the compilation error caused by the libsqlite3-sys v0.36 API changes.
Out of Scope Changes check	✅ Passed	All changes are directly related to the dependency upgrade and API adaptation required by libsqlite3-sys v0.36; no out-of-scope modifications are present.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ec75888 and 6798c26.

⛔ Files ignored due to path filters (1)

Cargo.lock is excluded by !**/*.lock

📒 Files selected for processing (2)

crates/stdlib/Cargo.toml
crates/stdlib/src/sqlite.rs

🧰 Additional context used

📓 Path-based instructions (1)

**/*.rs

📄 CodeRabbit inference engine (.github/copilot-instructions.md)

**/*.rs: Follow the default rustfmt code style by running cargo fmt to format Rust code
Always run clippy to lint Rust code (cargo clippy) before completing tasks and fix any warnings or lints introduced by changes
Follow Rust best practices for error handling and memory management
Use the macro system (pyclass, pymodule, pyfunction, etc.) when implementing Python functionality in Rust

Files:

crates/stdlib/src/sqlite.rs

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)

GitHub Check: Run rust tests (ubuntu-latest)
GitHub Check: Run snippets and cpython tests (ubuntu-latest)
GitHub Check: Run snippets and cpython tests (macos-latest)
GitHub Check: Run snippets and cpython tests (windows-latest)
GitHub Check: Run rust tests (windows-latest)
GitHub Check: Run rust tests (macos-latest)
GitHub Check: Check the WASM package and demo
GitHub Check: Run snippets and cpython tests on wasm-wasi
GitHub Check: Ensure compilation on various targets
GitHub Check: Check Rust code with clippy
GitHub Check: Run tests under miri

🔇 Additional comments (3)

crates/stdlib/src/sqlite.rs (2)

33-33: LGTM! Import updated to match libsqlite3-sys v0.36 API.

The import correctly switches from sqlite3_close_v2 to sqlite3_close to align with the new library version's exported symbols.

1352-1359: LGTM! Type casts removed as SQLITE_TRACE_STMT now has the correct type.

The explicit as u32 casts are no longer needed because SQLITE_TRACE_STMT is now properly typed as c_uint in libsqlite3-sys v0.36. This improves type safety.

crates/stdlib/Cargo.toml (1)

135-135: The review comment's primary concern is incorrect. Web search confirms that sqlite3_close_v2 was not removed in libsqlite3-sys 0.36.0; the function remains available from the underlying SQLite library (added in SQLite 3.7.14). The code change to use sqlite3_close is a deliberate API choice, not an adaptation to removal.

The version bump from 0.28 to 0.36 is a standard update to the current stable release. v0.36.0 release notes document only additive changes: new bindings, hook-related code improvements, and a bump of the bundled SQLite to version 3.49.2—no breaking API removals.

Likely an incorrect or invalid review comment.

ever0de added 2 commits December 24, 2025 01:51

Bump libsqlite3-sys from 0.28 to 0.36 …

5008c83

Update libsqlite3-sys to version 0.36 and adapt to API changes by replacing sqlite3_close_v2 with sqlite3_close. The v2 variant is no longer directly exported in the newer version. Fixes RustPython#6471

Fix clippy

6798c26

coderabbitai Bot reviewed Dec 23, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump libsqlite3-sys from 0.28 to 0.36#6472