Pre-merge checks and finishing touches

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Code has been automatically formatted

The code in this PR has been formatted using cargo fmt --all.
Please pull the latest changes before pushing again:

git pull origin copilot/fix-attributeerror-xmlparser

Looks great!

Resolve additional unexpected success:...

Fixed in c9be4ac - removed @unittest.expectedFailure from test_parse_str and test_parse_file as they now pass.

Regarding test_socket: I verified it passes successfully (39.9s) on this branch. The test doesn't use any XML/pyexpat functionality, and my changes only modified crates/stdlib/src/pyexpat.rs and Lib/test/test_pyexpat.py. Could you provide more details about the test_socket failure you're seeing? It might be an intermittent CI issue or from a different context.

@coderabbitai review

@copilot please check @coderabbitai's review

#!/bin/bash
# Fetch CodeRabbit's review comments on PR #6494
gh pr view 6494 --json reviews,comments --jq '.reviews[] | select(.author.login == "coderabbitai[bot]") | {state: .state, body: .body, submittedAt: .submittedAt}'

# Also fetch review comments (line-specific comments)
gh api repos/RustPython/RustPython/pulls/6494/comments --jq '.[] | select(.user.login == "coderabbitai[bot]") | {path: .path, line: .line, body: .body, created_at: .created_at}' | head -50

#!/bin/bash
# Search for namespace_prefixes usage in RustPython's test files and stdlib
rg -n "namespace_prefixes" --type=py -C 3

# Check if there are any Python test files that demonstrate the actual usage
fd -e py test_xml -x cat {}

# Look for xml.dom.minidom usage patterns
rg -n "expatbuilder|minidom" --type=py -C 2

#!/bin/bash
# Find XML-related test files
fd -e py . | grep -i xml

# Look for the issue reference in commit messages or code
rg -n "6487" --type=py

# Check what's in the pyexpat test directory
find . -path "*/test*" -name "*xml*" -o -name "*expat*" | head -20

# Look at the actual changes in the pyexpat.rs file to see the implementation
grep -n "namespace_prefixes" crates/stdlib/src/pyexpat.rs

CPython xml.dom.expatbuilder namespace_prefixes source code

CPython expatbuilder.py namespace_prefixes parser attribute code

CPython pyexpat xmlparser intern attribute exposed

@youknowone, I'm CodeRabbit responding to your request. Let me clarify my review findings after further investigation:

Review Correction

My review comment flagged both namespace_prefixes and intern as non-standard attributes. After investigating CPython's source code, I need to correct part of that assessment:

✅ namespace_prefixes - Valid CPython Attribute

CPython's pyexpat C module does expose a namespace_prefixes attribute on the xmlparser object. When set, it calls XML_SetReturnNSTriplet to enable namespace prefix reporting. This attribute is used by xml.dom.expatbuilder and xml.etree.ElementTree internally.

My review comment was incorrect about this attribute. The implementation in this PR is correct and needed for compatibility with CPython's xml.dom.minidom (as mentioned in issue #6487).

❌ intern - Non-Standard Attribute

CPython's xml.parsers.expat xmlparser does not expose an "intern" attribute. String interning in CPython's XML parsing is handled through SAX's feature_string_interning mechanism, not as a direct xmlparser attribute.

My review comment was correct about this attribute. The intern attribute at line 182 in crates/stdlib/src/pyexpat.rs should either be:

• Removed for strict CPython compatibility, or
• Documented as a RustPython extension with a comment explaining the divergence

Recommendation

The namespace_prefixes implementation is correct and should remain. However, please address the intern attribute by either removing it or adding documentation explaining why it differs from CPython's API.

🐰💭

Learnt from: youknowone
URL: https://github.com/RustPython/RustPython/pull/6494

Timestamp: 2025-12-24T23:47:38.444Z
Learning: CPython's xml.parsers.expat xmlparser exposes a namespace_prefixes boolean attribute (implemented in the pyexpat C module) that controls namespace prefix reporting via XML_SetReturnNSTriplet. This attribute is used internally by xml.dom.expatbuilder and xml.etree.ElementTree.

Learnt from: youknowone
URL: https://github.com/RustPython/RustPython/pull/6494

Timestamp: 2025-12-24T23:47:38.444Z
Learning: CPython's xml.parsers.expat xmlparser does not expose an intern attribute. String interning for XML parsing in CPython is handled through SAX's expatreader feature_string_interning mechanism, not as a direct xmlparser.intern attribute.

@copilot please check @coderabbitai's review

I've reviewed the code and verified that:

✅ All tests pass (test_xml_etree, SetAttributeTest, ParseTest)
✅ Clippy passes with no warnings
✅ Code follows Rust best practices

However, I don't see the actual review comments from @coderabbitai in the thread. Could you share the specific concerns or suggestions from the review so I can address them?

@copilot #6494 (comment)

@copilot #6494 (comment)

I'm unable to access external URLs directly. Could you please paste the specific review comments from @coderabbitai here so I can address them? Alternatively, if there are specific changes you'd like me to make based on that review, please let me know.

@copilot

❌ intern - Non-Standard Attribute
CPython's xml.parsers.expat xmlparser does not expose an "intern" attribute. String interning in CPython's XML parsing is handled through SAX's feature_string_interning mechanism, not as a direct xmlparser attribute.

My review comment was correct about this attribute. The intern attribute at line 182 in crates/stdlib/src/pyexpat.rs should either be:

Removed for strict CPython compatibility, or
Documented as a RustPython extension with a comment explaining the divergence

please verify it is correct and continue

@copilot

❌ intern - Non-Standard Attribute
...

The review comment is incorrect. CPython's xml.parsers.expat xmlparser does expose an intern attribute as a dictionary.

Evidence:

1. ✅ CPython 3.12: hasattr(parser, 'intern') returns True, type is dict
2. ✅ Used in CPython's own code: Lib/xml/dom/expatbuilder.py line 159: self._intern_setdefault = self._parser.intern.setdefault
3. ✅ Listed as a data attribute alongside namespace_prefixes, ordered_attributes, specified_attributes
4. ✅ Our implementation works correctly with the expatbuilder code path from the original issue

The intern attribute is for string interning of element/attribute names for memory efficiency and should remain as implemented.