◐ Shell
reader mode source ↗
Skip to content

Update Straightforward packages Pt 2#6599

Closed
terryluan12 wants to merge 24 commits into
RustPython:mainfrom
terryluan12:update_simple_packages_2
Closed

Update Straightforward packages Pt 2#6599
terryluan12 wants to merge 24 commits into
RustPython:mainfrom
terryluan12:update_simple_packages_2

Conversation

@terryluan12

@terryluan12 terryluan12 commented Dec 30, 2025

Copy link
Copy Markdown
Contributor

This PR updates the following libraries:

  • enum.py + test_enum.py
  • filecmp.py + test_filecmp.py`
  • fractions.py + test_fractions.py
  • ftplib.py + test_ftplib.py
  • hmac.py + test_hmac.py
  • mailbox.py + test_mailbox.py
  • nturl2path.py
  • pkgutil.py + test_pkgutil.py
  • pathlib.py
  • platform.py + test_platform.py
  • plistlib.py + test_plistlib.py

It also adds test_pathlib, which works mostly the same to with CPython (I was unable to test it with a Windows desktop + added clarifications to the top of the test_pathlib.py on which tests were skipped)

Helps with #5529

@terryluan12
Updated bdb.py + test_bdb.py
b0ec8ee
@terryluan12
Deleted _pycodecs.py
91d4447
@terryluan12
Updated code.py library
ac9bd54
@terryluan12
Updated the _pydatetime.py lib
d5f6198
@terryluan12
Removed distutils package
f585018
@terryluan12
Updated doctest package
da4a841
@terryluan12
* Updated datetimetester.py …
d7405c9 
* Added back in _pycodecs.py
@terryluan12
Updated enum and test_enum.py
e82917e
@terryluan12
Updated filecmp + test_filecmp
6e59ca5
@terryluan12
Updated fractions + test_fractions
aae2dcf
@terryluan12
Updated ftplib + test_ftplib
fd34286
@terryluan12
Updated hmac + test_hmac
77db70c
@terryluan12
* Updated mailbox + added test_mailbox.py
7c13c61
@terryluan12
Updated nturl2path.py
3752174
@terryluan12
Added pathlib + test_pathlib packages
cd5865e
@terryluan12
Updated pkgutil.py & test_pkgutil.py
0e3365a
@terryluan12
Updated platform.py + test_platform.py
d313adc
@terryluan12
Updated plistlib + test_plistlib
6da715b
@terryluan12
Merge branch 'add_tests' into update_simple_packages_2
2ee4e37
@terryluan12
Updated enum and plistlib tests using the script
28493a7
@terryluan12
Updated pkgutil test with the script …
312f7d9 
* Updated test/test_import
@terryluan12
Ran/updated ftplib +test_hmac + pathlib tests with the script
39f990e
@terryluan12
Added comment to pathlib
1cd4ad6
@terryluan12
Clarified the comments at the top of test_pathlib
88857d9
@coderabbitai

coderabbitai Bot commented Dec 30, 2025

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (35)
  • Lib/enum.py is excluded by !Lib/**
  • Lib/filecmp.py is excluded by !Lib/**
  • Lib/fractions.py is excluded by !Lib/**
  • Lib/ftplib.py is excluded by !Lib/**
  • Lib/hmac.py is excluded by !Lib/**
  • Lib/mailbox.py is excluded by !Lib/**
  • Lib/nturl2path.py is excluded by !Lib/**
  • Lib/pathlib/__init__.py is excluded by !Lib/**
  • Lib/pathlib/_abc.py is excluded by !Lib/**
  • Lib/pathlib/_local.py is excluded by !Lib/**
  • Lib/pkgutil.py is excluded by !Lib/**
  • Lib/platform.py is excluded by !Lib/**
  • Lib/plistlib.py is excluded by !Lib/**
  • Lib/test/datetimetester.py is excluded by !Lib/**
  • Lib/test/test_enum.py is excluded by !Lib/**
  • Lib/test/test_filecmp.py is excluded by !Lib/**
  • Lib/test/test_fractions.py is excluded by !Lib/**
  • Lib/test/test_ftplib.py is excluded by !Lib/**
  • Lib/test/test_hmac.py is excluded by !Lib/**
  • Lib/test/test_import/__init__.py is excluded by !Lib/**
  • Lib/test/test_import/data/circular_imports/import_cycle.py is excluded by !Lib/**
  • Lib/test/test_import/data/circular_imports/singlephase.py is excluded by !Lib/**
  • Lib/test/test_import/data/double_const.py is excluded by !Lib/**
  • Lib/test/test_import/data/package3/__init__.py is excluded by !Lib/**
  • Lib/test/test_import/data/package3/submodule.py is excluded by !Lib/**
  • Lib/test/test_import/data/package4/__init__.py is excluded by !Lib/**
  • Lib/test/test_import/data/package4/submodule.py is excluded by !Lib/**
  • Lib/test/test_mailbox.py is excluded by !Lib/**
  • Lib/test/test_pathlib.py is excluded by !Lib/**
  • Lib/test/test_pathlib/__init__.py is excluded by !Lib/**
  • Lib/test/test_pathlib/test_pathlib.py is excluded by !Lib/**
  • Lib/test/test_pathlib/test_pathlib_abc.py is excluded by !Lib/**
  • Lib/test/test_pkgutil.py is excluded by !Lib/**
  • Lib/test/test_platform.py is excluded by !Lib/**
  • Lib/test/test_plistlib.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@terryluan12 terryluan12 changed the title Update Straightforward packages Pt 3 Dec 30, 2025
@youknowone

youknowone commented Dec 31, 2025

Copy link
Copy Markdown
Member

@terryluan12 The changes seem to cause hang. Could you split this PR to smaller one to find out what's the cause?

@youknowone

youknowone commented Dec 31, 2025

Copy link
Copy Markdown
Member

that's the next one of builtin_eval. probably ./extra_tests/snippets/builtin_exceptions.py

@terryluan12

terryluan12 commented Dec 31, 2025

Copy link
Copy Markdown
Contributor Author

@terryluan12 The changes seem to cause hang. Could you split this PR to smaller one to find out what's the cause?

Yep, absolutely!

that's the next one of builtin_eval. probably ./extra_tests/snippets/builtin_exceptions.py

Can you clarify what you mean by this?

@terryluan12

terryluan12 commented Dec 31, 2025

Copy link
Copy Markdown
Contributor Author

I've separated this out into separate PR's:

#6606
#6607
#6608
#6609
#6610
#6611

@terryluan12 terryluan12 deleted the update_simple_packages_2 branch January 5, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@terryluan12 @youknowone