◐ Shell
reader mode source ↗
Skip to content

Updated the hmac + mailbox libraries + associated tests#6608

Merged
youknowone merged 3 commits into
RustPython:mainfrom
terryluan12:hmac_mailbox
Dec 31, 2025
Merged

Updated the hmac + mailbox libraries + associated tests#6608
youknowone merged 3 commits into
RustPython:mainfrom
terryluan12:hmac_mailbox

Conversation

@terryluan12

@terryluan12 terryluan12 commented Dec 31, 2025

Copy link
Copy Markdown
Contributor

The mailbox library test is a new addition, but local testing worked fine, and nothing needed to be changed for me from the CPython version

@coderabbitai

coderabbitai Bot commented Dec 31, 2025

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (4)
  • Lib/hmac.py is excluded by !Lib/**
  • Lib/mailbox.py is excluded by !Lib/**
  • Lib/test/test_hmac.py is excluded by !Lib/**
  • Lib/test/test_mailbox.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@terryluan12 terryluan12 mentioned this pull request Dec 31, 2025
Closed
youknowone
youknowone approved these changes Dec 31, 2025
View reviewed changes

@youknowone youknowone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

👍

Hide details View details @youknowone youknowone merged commit bd0aaf6 into RustPython:main Dec 31, 2025
13 checks passed
@fanninpm fanninpm mentioned this pull request Jan 2, 2026
Closed
@terryluan12 terryluan12 deleted the hmac_mailbox branch January 5, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@terryluan12 @youknowone