◐ Shell
reader mode source ↗
Skip to content

Updated the pkgutil + unittest libraries + the pkgutil, unittest and import tests - v.3.13.11#6610

Merged
youknowone merged 5 commits into
RustPython:mainfrom
terryluan12:update_pkgutil_pathlib
Jan 4, 2026
Merged

Updated the pkgutil + unittest libraries + the pkgutil, unittest and import tests - v.3.13.11#6610
youknowone merged 5 commits into
RustPython:mainfrom
terryluan12:update_pkgutil_pathlib

Conversation

@terryluan12

@terryluan12 terryluan12 commented Dec 31, 2025

Copy link
Copy Markdown
Contributor

I don't have access to Windows for now, so I've added comments to the top of the relevant test_pathlib files

@coderabbitai

coderabbitai Bot commented Dec 31, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (22)
  • Lib/pkgutil.py is excluded by !Lib/**
  • Lib/test/test_import/__init__.py is excluded by !Lib/**
  • Lib/test/test_import/data/circular_imports/import_cycle.py is excluded by !Lib/**
  • Lib/test/test_import/data/circular_imports/singlephase.py is excluded by !Lib/**
  • Lib/test/test_import/data/double_const.py is excluded by !Lib/**
  • Lib/test/test_import/data/package3/__init__.py is excluded by !Lib/**
  • Lib/test/test_import/data/package3/submodule.py is excluded by !Lib/**
  • Lib/test/test_import/data/package4/__init__.py is excluded by !Lib/**
  • Lib/test/test_import/data/package4/submodule.py is excluded by !Lib/**
  • Lib/test/test_pkgutil.py is excluded by !Lib/**
  • Lib/test/test_unittest/test_async_case.py is excluded by !Lib/**
  • Lib/test/test_unittest/test_discovery.py is excluded by !Lib/**
  • Lib/test/test_unittest/test_loader.py is excluded by !Lib/**
  • Lib/test/test_unittest/test_program.py is excluded by !Lib/**
  • Lib/test/test_unittest/test_runner.py is excluded by !Lib/**
  • Lib/test/test_unittest/testmock/testasync.py is excluded by !Lib/**
  • Lib/test/test_unittest/testmock/testhelpers.py is excluded by !Lib/**
  • Lib/test/test_unittest/testmock/testpatch.py is excluded by !Lib/**
  • Lib/unittest/__init__.py is excluded by !Lib/**
  • Lib/unittest/async_case.py is excluded by !Lib/**
  • Lib/unittest/loader.py is excluded by !Lib/**
  • Lib/unittest/main.py is excluded by !Lib/**

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@terryluan12 terryluan12 mentioned this pull request Dec 31, 2025
Closed
@terryluan12 terryluan12 changed the title Updated the pkgutil + pathlib libraries Dec 31, 2025
@terryluan12 terryluan12 changed the title Updated the pkgutil, pathlib, importlib + unittest libraries Dec 31, 2025
@terryluan12 terryluan12 changed the title Updated the pkgutil, pathlib, importlib, dbm, shelve & unittest libraries Dec 31, 2025
@youknowone

youknowone commented Jan 1, 2026

Copy link
Copy Markdown
Member

dbm is updated in #6616
shelve will be updated in #6483

@fanninpm fanninpm mentioned this pull request Jan 2, 2026
Closed
@terryluan12

terryluan12 commented Jan 3, 2026

Copy link
Copy Markdown
Contributor Author

dbm is updated in #6616 shelve will be updated in #6483

Sounds good. Removed from the title. Is there anything else I should do?

Also as an FYI, _test_multiprocessing.py is failing now, so I'm updating _test_multiprocessing.py + the multiprocessing library

@terryluan12 terryluan12 changed the title Updated the pkgutil, pathlib, importlib, dbm, shelve & unittest libraries - v.3.13.10 Jan 3, 2026
@youknowone

youknowone commented Jan 3, 2026

Copy link
Copy Markdown
Member

@terryluan12 Thank you so much! Could you also rebase this to remove test_import, which is already merged? And I recently updated multiprocessing to 3.13.11. Could you also check again if it is patching backward?

@terryluan12

terryluan12 commented Jan 3, 2026

Copy link
Copy Markdown
Contributor Author

@youknowone taking a look, I think I may completely refactor the history, as pathlib and importlib was already imported, which means quite a lot of refactoring would need to be done anyways. Can you clarify, do you mean importlib? Taking a look, it actually seems like importlib was updated, but not test_import

@youknowone

youknowone commented Jan 3, 2026

Copy link
Copy Markdown
Member

Using git reset to prev commit and adding only indented files will be helpful. Then cherrypick or rebase will be easy

@terryluan12 terryluan12 force-pushed the update_pkgutil_pathlib branch 2 times, most recently from d35f1ec to 6a06f94 Compare January 3, 2026 06:30
@terryluan12 terryluan12 changed the title Updated the pkgutil, pathlib, importlib, multiprocessing & unittest libraries - v.3.13.10 Jan 3, 2026
youknowone
youknowone approved these changes Jan 4, 2026
View reviewed changes

@youknowone youknowone left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Thank you!

@youknowone youknowone force-pushed the update_pkgutil_pathlib branch from 08f156f to b4ce088 Compare January 4, 2026 00:23
Hide details View details @youknowone youknowone merged commit 4bec6bb into RustPython:main Jan 4, 2026
12 of 13 checks passed
terryluan12 added a commit to terryluan12/RustPython that referenced this pull request Jan 5, 2026
@terryluan12
Updated the pkgutil + unittest libraries + the pkgutil, unittest and … …
4185dc9 
…import tests - v.3.13.11 (RustPython#6610)

* Updated unittest + tests

* Updated pkgutil + the associated test

* Updated test_import

* Fixed import + unittest test errors

* Updated test_dll_dependency_import with expectedFailure
terryluan12 added a commit to terryluan12/RustPython that referenced this pull request Jan 5, 2026
@terryluan12
Updated the pkgutil + unittest libraries + the pkgutil, unittest and … …
ca28ddd 
…import tests - v.3.13.11 (RustPython#6610)

* Updated unittest + tests

* Updated pkgutil + the associated test

* Updated test_import

* Fixed import + unittest test errors

* Updated test_dll_dependency_import with expectedFailure
terryluan12 added a commit to terryluan12/RustPython that referenced this pull request Jan 5, 2026
@terryluan12
Updated the pkgutil + unittest libraries + the pkgutil, unittest and … …
a733b8d 
…import tests - v.3.13.11 (RustPython#6610)

* Updated unittest + tests

* Updated pkgutil + the associated test

* Updated test_import

* Fixed import + unittest test errors

* Updated test_dll_dependency_import with expectedFailure
@terryluan12 terryluan12 deleted the update_pkgutil_pathlib branch January 5, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@youknowone youknowone youknowone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@terryluan12 @youknowone