update test_sys from 3.14.2#6781

youknowone

Summary by CodeRabbit

New Features
- Added a system-level function to query remote debugging availability (returns false).
- Exposed an implementation flag indicating isolated interpreter support (set to false).
Refactor
- Internal declaration layout for ABI flags was reorganized (no behavioral change).

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai

📝 Walkthrough

Walkthrough

Added a new sys-level function is_remote_debug_enabled() (always false), introduced an internal ABIFLAGS_ATTR constant while keeping ABIFLAGS exported, and added "supports_isolated_interpreters": false to the sys.implementation namespace in two construction sites.

Changes

Cohort / File(s)	Summary
Sys module: API & constants `crates/vm/src/stdlib/sys.rs`	Added internal `ABIFLAGS_ATTR: &str = "t"`; retained `pub(crate) ABIFLAGS: &str = "t"` with adjusted declaration layout.
Sys module: runtime flags `crates/vm/src/stdlib/sys.rs`	Added `const fn is_remote_debug_enabled() -> bool` (PyFunction) returning `false`.
Sys module: implementation namespace `crates/vm/src/stdlib/sys.rs`	Inserted `"supports_isolated_interpreters" => ctx.new_bool(false)` into both `sys.implementation` namespace constructions (duplicate presence).

Sequence Diagram(s)

(Skipped — changes are small API/flag additions without multi-component control flow.)

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

Update test_sys.py from 3.13.11 #6428 — Adds similar sys-level boolean-returning function(s) (e.g., _is_gil_enabled), touching the same crates/vm/src/stdlib/sys.rs area; likely related API work.

Poem

🐰 Hippity-hop, a flag and a name,
False for remote, the rabbit proclaims.
ABIFLAGS tucked in a quieter place,
Isolated interpreters kept out of the race.
Tiny change, big cheer—snack time, hooray! 🥕

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'update test_sys from 3.14.2' is vague and does not clearly communicate the main changes made to the sys module, which include adding is_remote_debug_enabled(), supports_isolated_interpreters flag, and ABIFLAGS reorganization.	Consider revising the title to be more specific about the actual changes, such as 'Add is_remote_debug_enabled() and supports_isolated_interpreters to sys module' or similar descriptive language that clarifies the primary modifications.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@crates/vm/src/stdlib/sys.rs`:
- Around line 632-636: The function is_remote_debug_enabled() is not part of
CPython 3.14 public API, so either remove it or make it explicitly a RustPython
extension: if this was accidental, delete the const fn is_remote_debug_enabled
and its #[pyfunction] entry from sys.rs; if intentional, rename it to a
RustPython-specific symbol (e.g., _rustpython_is_remote_debug_enabled or keep
the Rust name but add a distinct Python name via #[pyfunction(name =
"_rustpython_is_remote_debug_enabled")]), add a doc comment stating it is a
RustPython extension, and gate it behind a feature flag (e.g., #[cfg(feature =
"rustpython_ext")]) so it does not pretend to be the CPython API.

youknowone marked this pull request as ready for review January 18, 2026 13:26

coderabbitai Bot reviewed Jan 18, 2026

View reviewed changes

youknowone and others added 2 commits January 18, 2026 23:11

sys.is_remote_debug_enabled, supports_isolated_interpreters

18c5cdd

Update test_sys form Python 3.14.2

f5121b8

youknowone force-pushed the sys branch from 9ccb5c1 to f5121b8 Compare January 18, 2026 14:11

youknowone deleted the sys branch January 18, 2026 14:58

coderabbitai Bot mentioned this pull request Mar 2, 2026

Update sysconfig from v3.14.3 and also fix _sysconfig #7296

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

update test_sys from 3.14.2#6781