libregrtest from 3.14.2#6818

youknowone

Summary by CodeRabbit

Refactor
- Updated timeout parameter implementation to accept a broader range of numeric input values with enhanced validation and improved error handling.
- Added robust edge-case management for special input values including negative numbers and numeric overflow detection.
- All core functionality and existing error handling mechanisms remain unchanged.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai

📝 Walkthrough

Walkthrough

The WaitForSingleObject function signature in the Windows API wrapper was updated to accept i64 milliseconds instead of u32. Input validation logic was added to map negative values to INFINITE, reject values exceeding u32::MAX with an overflow error, and cast valid values to u32 for the underlying Windows API call.

Changes

Cohort / File(s)	Summary
WaitForSingleObject validation enhancement `crates/vm/src/stdlib/winapi.rs`	Updated function signature to accept `ms: i64` parameter. Added downstream validation: negative values map to INFINITE, overflow checking for values exceeding u32::MAX, and conditional casting to u32.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A timer once bound by thirty-two bits,
Now takes the full range—no more throwing fits!
We handle the negatives, check for the spills,
And cast safely down through validation's mills.
Windows will wait, and our logic rings true,
A hop toward robustness, through and through! 🐇

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The PR title 'libregrtest from 3.14.2' does not align with the actual changes, which involve updating WaitForSingleObject function signature and adding input validation for the Windows API wrapper.	Update the PR title to accurately reflect the main change, such as 'Update WaitForSingleObject signature to accept i64 with validation' or 'Add input validation to WaitForSingleObject for ms parameter'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@crates/stdlib/src/gc.rs`:
- Around line 5-13: The module attribute definition for gc.garbage uses
#[pyattr] which recreates an empty list on each access; change the attribute to
#[pyattr(once)] on the garbage function so the created list is stored/persistent
across accesses (matching CPython semantics) — update the attribute macro on the
garbage function (fn garbage(vm: &VirtualMachine) -> PyObjectRef) to
#[pyattr(once)] so gc.garbage returns the same mutable list instance each time.

youknowone force-pushed the regrtest branch from 41daaca to fed77cd Compare January 20, 2026 16:12

youknowone marked this pull request as ready for review January 20, 2026 16:23

coderabbitai Bot reviewed Jan 20, 2026

View reviewed changes

fanninpm reviewed Jan 20, 2026

View reviewed changes

youknowone force-pushed the regrtest branch 2 times, most recently from eff49b4 to 6c17e07 Compare January 21, 2026 09:14

youknowone added 2 commits January 21, 2026 20:44

winapi.WaitForSingleObject

2fb2a7e

Update libregrtest from v3.14.2

9e9bfa5

youknowone force-pushed the regrtest branch from 6c17e07 to 9e9bfa5 Compare January 21, 2026 11:44

youknowone deleted the regrtest branch January 21, 2026 12:35

fanninpm mentioned this pull request Jan 30, 2026

Regrtest upgrade #5752

Closed

coderabbitai Bot mentioned this pull request Feb 4, 2026

Align winapi with CPython behavior #6988

Merged

coderabbitai Bot mentioned this pull request Mar 8, 2026

Wait for overlapped WriteFile completion in Rust #7383

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

libregrtest from 3.14.2#6818