Fix update_lib tests#6866

youknowone

Summary by CodeRabbit

Tests
- Improved test coverage for Python module auto-detection, including validation of modules following specific naming patterns.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

coderabbitai

📝 Walkthrough

Walkthrough

A test case has been replaced to validate auto-detection of Python modules matching the _py{module}.py pattern. The new test creates a temporary directory with datetime.py and _pydatetime.py, then verifies that get_lib_paths() returns both files.

Changes

Cohort / File(s)	Summary
Test auto-detection for Python module pattern `scripts/update_lib/tests/test_deps.py`	Replaced test case asserting behavior for a known dependency with a new test validating auto-detection of `_py{module}.py` pattern modules; creates temporary Lib directory and verifies `get_lib_paths()` returns both `datetime.py` and `_pydatetime.py`

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

Possibly related PRs

update_lib hard dependency resolver #6817: The test change directly validates the dependency resolver's auto-detection behavior for _py{module}.py hard-dependencies introduced in that PR.
CI runs update_lib #6835: Related through shared test suite—adds CI step that runs scripts/update_lib tests that this change modifies.

Suggested reviewers

moreal
ShaharNaveh

Poem

🐰 A module hops through Lib with care,
DateTime and its twin pair,
Auto-detect, no need to guess,
Dependency patterns—nothing less!
_py friends now pass the test with flair ✨

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'Fix update_lib tests' is vague and generic, not clearly describing the specific change being made.	Consider a more descriptive title such as 'Add auto-detection test for Python module patterns in update_lib' to clarify the main change.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@scripts/update_lib/tests/test_deps.py`:
- Around line 67-79: The new assertions and file creation in
test_auto_detect_py_module violate the repo's policy against adding or changing
test logic; revert this test change so the file only contains allowed edits
(e.g., expectedFailure decorators) or coordinate an exception with maintainers.
Specifically, undo the added creation of (lib_dir / "datetime.py") and (lib_dir
/ "_pydatetime.py") and the additional assertions around
get_lib_paths("datetime", ...) so test_auto_detect_py_module returns to its
prior state.

Fix update_lib tests

e93e9d4

youknowone marked this pull request as ready for review January 24, 2026 13:01

coderabbitai Bot reviewed Jan 24, 2026

View reviewed changes

youknowone deleted the update_lib-test branch January 24, 2026 13:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix update_lib tests#6866