no_std for wtf8, sre_engine, compiler-core, literal#7051

youknowone

Summary by CodeRabbit

New Features
- Exposed new public modules and constants for search engine operations and literal handling.
Refactor
- Updated formatter method signatures across multiple modules to ensure consistency with core formatting interfaces.

coderabbitai

📝 Walkthrough

Walkthrough

Multiple crates migrate to no_std compilation by adding #![no_std] attributes, replacing std:: imports with core:: and alloc:: equivalents, and updating formatter trait parameters from std::fmt::Write to core::fmt::Write. Public module structures and re-exports are added where needed.

Changes

Cohort / File(s)	Summary
compiler-core no_std imports `crates/compiler-core/src/bytecode.rs`, `crates/compiler-core/src/frozen.rs`, `crates/compiler-core/src/marshal.rs`, `crates/compiler-core/src/varint.rs`	Added `alloc::` imports (Vec, Box, String, ToOwned) to support heap allocation in no_std context.
compiler-core lib root `crates/compiler-core/src/lib.rs`	Added `#![no_std]` attribute to enable no_std compilation for the crate.
literal no_std imports `crates/literal/src/complex.rs`, `crates/literal/src/float.rs`	Added `alloc::` and `core::` imports (String, ToString, ToOwned, format, f64) to replace std equivalents.
literal public API formatter refactor `crates/literal/src/escape.rs`	Updated public function signatures and trait implementations to use `core::fmt::Write` instead of `std::fmt::Write` across Escape, StrRepr, UnicodeEscape, AsciiEscape, and BytesRepr. Added `alloc::string::String` import.
literal lib root `crates/literal/src/lib.rs`	Added `#![no_std]` attribute and declared new public modules `pub mod float;` and `pub mod format;`.
sre_engine no_std imports `crates/sre_engine/src/engine.rs`	Added `alloc::{vec, vec::Vec}` import to support Vec in no_std context.
sre_engine lib root `crates/sre_engine/src/lib.rs`	Added `#![no_std]` and `extern crate alloc;`, declared public modules and constants, added platform-specific `MAXREPEAT` and `MAXGROUPS` constants via cfg attributes.
wtf8 no_std migration `crates/wtf8/src/lib.rs`	Added `#![no_std]` and `extern crate alloc;`, replaced std imports with core/alloc equivalents (Borrow, Cow, String, Vec, from_utf8, mem::take, iter::once), updated Write trait usage to `core::fmt::Write`.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Possibly related PRs

no_std clippy #7043: Performs the same no_std/alloc migration pattern (switching std → core/alloc imports and adding #![no_std] across crates).
finish no_std clippy #6587: Contains related no_std migration-style changes (replacing std imports with core/alloc equivalents across multiple modules).

Suggested reviewers

ShaharNaveh
coolreader18
fanninpm

Poem

🐰 Hopping through imports with glee,
From std:: to core so free,
No heap, no fuss—just alloc's call,
We've gone no_std, and that's all! 🌟

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The PR title directly and clearly describes the main objective: converting four crates to no_std compatibility.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@crates/wtf8/src/lib.rs`:
- Around line 36-46: The workspace dependency for itertools must be configured
for no_std; update the Cargo.toml entry for itertools to disable default
features and enable its alloc support by setting itertools = { version =
"0.14.0", default-features = false, features = ["use_alloc"] } so the crate
using #![no_std] and alloc (see extern crate alloc and uses like
itertools::Either / itertools::Itertools) compiles without pulling in std.

youknowone added 2 commits February 9, 2026 00:24

no_std for wtf8

a96977f

no_std for sre_engine, compiler-core, literal

2c5ece9

youknowone marked this pull request as ready for review February 8, 2026 15:25

coderabbitai Bot reviewed Feb 8, 2026

View reviewed changes

youknowone deleted the no_std branch February 8, 2026 16:04

coderabbitai Bot mentioned this pull request Feb 9, 2026

no_std for common, pylib, codegen #7056

Merged

coderabbitai Bot mentioned this pull request Feb 24, 2026

Remove PyStr::as_str #7218

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

no_std for wtf8, sre_engine, compiler-core, literal#7051