Walkthrough

Centralized environment-mapping→dict conversion into crate::stdlib::os::envobj_to_dict and replaced local helpers in posix.rs and nt.rs. In posix.rs, changed child after-fork callback acquisition to try a non-blocking lock with a force-unlock fallback before cloning the callback list.

Changes

Sequence Diagram(s)

sequenceDiagram
    participant Parent
    participant Fork as fork()
    participant Child
    participant Lock as after_fork_lock
    participant Callbacks

    Parent->>Fork: fork()
    Fork-->>Child: child process starts
    Child->>Lock: try_lock() (non-blocking)
    alt lock acquired
        Lock-->>Child: guard
    else lock busy
        Child->>Lock: force_unlock state
        Child->>Lock: lock() (blocking)
        Lock-->>Child: guard
    end
    Child->>Callbacks: clone callback list from guard
    Child->>Callbacks: execute after-fork callbacks

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• Update os from v3.14.2 and fix nt,posix,_os #6958: Centralizes env mapping conversion and removes local helpers in posix/nt, touching the same env conversion refactor.
• impl more nt #6984: Related changes to env/execve paths and validation where envobj_to_dict is used.
• clear_after_fork #6933: Changes to after-fork child handling that overlap with the posix fork callback modifications.

Poem

🐰
I hopped through locks in forked daylight,
Moved env maps into one tidy night,
I try-locked, forced when things were tight,
Cloned callbacks, then set them right,
A tiny hop, a cleaner byte.

❌ Failed checks (1 warning)

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

• 📝 Generate docstrings

• X
• Mastodon
• Reddit
• LinkedIn