◐ Shell
reader mode source ↗
Skip to content

Unified action for installing macos deps#7379

Merged
youknowone merged 2 commits into
RustPython:mainfrom
ShaharNaveh:ci-install-macos-deps
Mar 7, 2026
Merged

Unified action for installing macos deps#7379
youknowone merged 2 commits into
RustPython:mainfrom
ShaharNaveh:ci-install-macos-deps

Conversation

@ShaharNaveh

@ShaharNaveh ShaharNaveh commented Mar 7, 2026

Copy link
Copy Markdown
Contributor

Taken and modified from https://github.com/bevyengine/bevy/blob/162a7080911dc8b782475553fef8888c8d103655/.github/actions/install-linux-deps/action.yml

Summary by CodeRabbit

Chores

  • Refactored macOS build environment setup for improved consistency and maintainability across CI/CD workflows.

@coderabbitai

coderabbitai Bot commented Mar 7, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Introduces a new reusable GitHub Action to install macOS build dependencies and refactors the CI workflow to use this action instead of inline brew commands, consolidating dependency setup logic in two workflow jobs.

Changes

Cohort / File(s) Summary
New macOS Dependency Action
.github/actions/install-macos-deps/action.yml
Defines a composite GitHub Action with inputs for autoconf, automake, libtool, and openssl. Conditionally installs selected packages via brew based on input flags.
CI Workflow Updates
.github/workflows/ci.yaml
Replaces inline brew install commands in rust_tests and snippets_cpython jobs with invocations of the new install-macos-deps action; adds openssl: true parameter in snippets_cpython job.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Suggested reviewers

  • youknowone

Poem

🐰 A rabbit hops through workflows, neat,
Bundling brew commands—oh what a treat!
Dependencies dance on macOS so bright,
Reusable actions make CI just right! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Unified action for installing macos deps' accurately describes the main change: introducing a composite GitHub Action to standardize macOS dependency installation across workflows.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hide comment

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In @.github/actions/install-macos-deps/action.yml:
- Around line 39-47: The "Install macOS dependencies" step currently runs "brew
install" even when no formulae are selected, causing a failure; change the step
to compute the list of chosen inputs (inputs.autoconf, inputs.automake,
inputs.libtool, inputs.openssl) into a variable and skip running "brew install"
when that computed list is empty (i.e., no-op or echo a message), otherwise run
"brew install <packages>"; update the step's run script to perform this
conditional check so the action does nothing if all inputs are false.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: d572a819-438a-405a-b51f-df21ad724e9e

📥 Commits

Reviewing files that changed from the base of the PR and between abfb51e and 37b82ca.

📒 Files selected for processing (2)
  • .github/actions/install-macos-deps/action.yml
  • .github/workflows/ci.yaml

Hide details View details @youknowone youknowone merged commit f680f8a into RustPython:main Mar 7, 2026
12 of 13 checks passed
youknowone pushed a commit to youknowone/RustPython that referenced this pull request Mar 8, 2026
* Add `install-macos-deps` action

* Use new action
youknowone pushed a commit to youknowone/RustPython that referenced this pull request Mar 22, 2026
* Add `install-macos-deps` action

* Use new action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants