Cargo.toml (1)

15-15: Consider propagating to rustpython-stdlib for consistency.

Other features like host_env (line 14) propagate to both rustpython-vm and rustpython-stdlib:

host_env = ["rustpython-vm/host_env", "rustpython-stdlib?/host_env"]

While ctypes only propagates to rustpython-vm. Since rustpython-stdlib/ctypes just forwards to rustpython-vm/ctypes, this works correctly, but for consistency you might consider:

ctypes = ["rustpython-vm/ctypes", "rustpython-stdlib?/ctypes"]

This is a minor consistency suggestion and not required for correctness.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@Cargo.toml` at line 15, Update the Cargo.toml feature entry for "ctypes" so
it also propagates to rustpython-stdlib like other features do; specifically
modify the "ctypes" feature definition (currently referencing
"rustpython-vm/ctypes") to include the rustpython-stdlib propagation (add
"rustpython-stdlib?/ctypes") so the feature list becomes
["rustpython-vm/ctypes", "rustpython-stdlib?/ctypes"] and maintains consistency
with other features such as "host_env".

crates/vm/Cargo.toml (1)

87-88: Potential redundancy with target-specific dependencies.

These optional dependencies overlap with the non-optional target-specific dependencies on lines 111-113:

[target.'cfg(all(any(target_os = "linux", target_os = "macos", target_os = "windows"), not(any(target_env = "musl", target_env = "sgx"))))'.dependencies]
libffi = { workspace = true, features = ["system"] }
libloading = "0.9"

On supported platforms (Linux/macOS/Windows, non-musl, non-SGX), libffi and libloading are always included regardless of the ctypes feature. The optional deps here are only meaningful for platforms outside that target condition where a user explicitly enables --features ctypes.

This design works but creates a subtle distinction: the ctypes feature is only necessary for "unsupported" platforms. Consider adding a comment to clarify this intent.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@crates/vm/Cargo.toml` around lines 87 - 88, The optional dependencies libffi
and libloading declared in the crate root (libffi = { workspace = true, features
= ["system"], optional = true } and libloading = { version = "0.9", optional =
true }) overlap with the non-optional target-specific dependencies under the
target.'cfg(... )'.dependencies block, so add a brief comment above the optional
deps explaining that they exist to enable the "ctypes" feature on unsupported
platforms (i.e., when the target cfg does not match Linux/macOS/Windows
non-musl/non-SGX) and that on supported platforms the target-specific section
will always supply these crates regardless of the ctypes feature.