.pre-commit-config.yaml (2)

24-31: Consider adding pass_filenames: false for consistency.

The script scripts/check_redundant_patches.py ignores CLI arguments and always scans the entire Lib/test directory (see lines 10-12 of the script). The current types_or: [python] setting passes filenames that are never used.

For clarity, consider:

♻️ Suggested improvement

       - id: redundant-test-patches
         name: Ensure no redundant test patches
         entry: python scripts/check_redundant_patches.py
         language: system
-        types_or: [python]
+        files: '^Lib/test/.*\.py$'
+        pass_filenames: false
         priority: 0

This makes the trigger more explicit (only run when test files change) and documents that filenames aren't used.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.pre-commit-config.yaml around lines 24 - 31, The hook
redundant-test-patches uses scripts/check_redundant_patches.py which ignores
passed filenames, so update the hook definition for id "redundant-test-patches"
to explicitly set pass_filenames: false and keep the existing entry ("python
scripts/check_redundant_patches.py") so pre-commit won't pass unused file args
to that script; this makes the hook intent explicit and avoids misleading
invocation semantics.

---

43-49: Add file filter to only trigger on relevant changes.

This hook runs on every commit since there's no files or types filter. The script only needs to run when crates/compiler-core/src/bytecode/instruction.rs changes.

♻️ Suggested improvement

       - id: generate-opcode-metadata
         name: Generate opcode metadata
         entry: python scripts/generate_opcode_metadata.py
         pass_filenames: false
         language: system
+        files: 'crates/compiler-core/src/bytecode/instruction\.rs$'
         require_serial: true # so rustfmt runs first
         priority: 1

This avoids unnecessary script execution and potential git status changes when the bytecode file hasn't been modified.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.pre-commit-config.yaml around lines 43 - 49, The pre-commit hook with id
"generate-opcode-metadata" currently runs on every commit; update its
configuration in .pre-commit-config.yaml to add a files filter that matches the
bytecode source file (crates/compiler-core/src/bytecode/instruction.rs) so the
hook only triggers when that file changes; locate the hook by the id/name
("generate-opcode-metadata" / "Generate opcode metadata") and add an appropriate
files entry (or types entry) to restrict execution to that path.

.github/workflows/ci.yaml (1)

355-358: Consider pinning cargo-shear version for reproducibility.

The cargo binstall --no-confirm cargo-shear command installs the latest version, which could cause unexpected CI failures if a new version introduces breaking changes or new lints.

♻️ Suggested improvement

       - name: cargo shear
         run: |
-          cargo binstall --no-confirm cargo-shear
+          cargo binstall --no-confirm cargo-shear@1.1.3
           cargo shear

Alternatively, Dependabot could manage this if cargo-shear is added as a dev-dependency.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/ci.yaml around lines 355 - 358, Pin the cargo-shear
installation in the "cargo shear" workflow step instead of installing the
latest: replace the current installer invocation (cargo binstall --no-confirm
cargo-shear) with a pinned installer command that specifies a known-good version
(e.g., cargo-shear@<version>), or add cargo-shear as a dev-dependency and let
Dependabot manage updates; update the workflow step that runs "cargo shear" to
rely on that pinned installation so CI remains reproducible.

.github/workflows/ci.yaml (1)

355-358: ⚠️ Potential issue | 🟠 Major

Line 357 still leaves cargo-shear floating.

Installing the current cargo-shear release on every run makes the unified lint job vulnerable to unrelated upstream breakage. cargo-binstall supports selecting an explicit package version, so this should be pinned too. (github.com)

♻️ Suggested fix

       - name: cargo shear
         run: |
-          cargo binstall --no-confirm cargo-shear
+          cargo binstall --no-confirm cargo-shear@<tested-version>
           cargo shear

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/ci.yaml around lines 355 - 358, The CI step named "cargo
shear" currently installs the latest cargo-shear with "cargo binstall
--no-confirm cargo-shear" which risks upstream breakage; change the install to
pin a specific release by using the cargo-binstall version syntax (e.g., replace
that line with "cargo binstall --no-confirm cargo-shear@<VERSION>") and keep
invoking the tool via "cargo shear" so the job installs a fixed cargo-shear
release instead of the floating latest.